fix: Template image for Helm Cleanup job due to bitnami updates#4242
fix: Template image for Helm Cleanup job due to bitnami updates#4242DaThumpingRabbit wants to merge 2 commits intoagones-dev:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Signed-off-by: sbene <Sebastien.bene.SbBn@gmail.com>
c67d9e7 to
d47b8bf
Compare
|
🤔 seems like a reasonable change - just wondering why we want to make it configurable? Might as well just switch to the rancher version and call it a day. Just a question of ongoign maintenance and documentation. |
|
Just noted, there is an official kubectl image: https://www.reddit.com/r/kubernetes/s/1rDLvH7rtR
|
I saw the image you mentioned but was a bit afraid about the stability warning
About this, I thought that maybe if some customers are paying the new bitnami secure package, they might want to switch back to bitnami |
|
@markmandel I have just made some tests and I don't think that this new image will be a good fit anyway since it does not come with a shell and won't work in that scenario Only alternative to bitnami I found for now that comes with a shell is alpine/k8s Please let me know if this would be a good alternative for this |
|
Apologies - this totally fell through the cracks. I did some pocking around - Looks like https://hub.docker.com/r/alpine/kubectl has an Sound good? |
Since Bitnami is doing stuff with their images, moving this to the alpine/kubectl image instead. It's a little ahead of what we use version wise -- but the helm job is very basic, and this is updated regularly, has a sh shell and has multiple architectures by default. Replaces PR agones-dev#4242 which seems to have stagnated.
|
Hope you don't mind - I ended up doing what I suggested in #4268 |
Since Bitnami is doing stuff with their images, moving this to the alpine/kubectl image instead. It's a little ahead of what we use version wise -- but the helm job is very basic, and this is updated regularly, has a sh shell and has multiple architectures by default. Replaces PR #4242 which seems to have stagnated. Co-authored-by: Thomas Lacroix <thomas.lacroix@ubisoft.com>
|
Closing, since I took care of this in #4268 Thanks for the heads up though! |
|
Yes sorry I also completely forgot about this |
What type of PR is this?
/kind hotfix
What this PR does / Why we need it:
Following this update bitnami/charts#35164, it will not be possible to keep using the kubectl image from bitnami for all users
This PR allows to choose what image to use to run the post-delete cleanup job and default on the best alternative I could find at the moment rancher/kubectl
Special notes for your reviewer:
Please let me know if bitnami should stay the default registry based on your guidelines