Adds support for lists in the Unreal SDK #4029 by keith-miller · Pull Request #4216 · agones-dev/agones

keith-miller · 2025-07-08T20:24:22Z

What type of PR is this?
/kind feature

What this PR does / Why we need it:
Adds support for lists to the Unreal SDK

Which issue(s) this PR fixes:
Closes #4029

Special notes for your reviewer:

markmandel · 2025-07-12T16:13:59Z

/gcbrun

agones-bot · 2025-07-12T17:21:23Z

Build Succeeded 🥳

Build Id: e19ce66e-028a-43bb-817a-9cb5e707a81d

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.51.0-dev-4403ced
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.51.0-dev-4403ced
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.51.0-dev-4403ced-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.51.0-dev-4403ced
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.51.0-dev-4403ced
Linux C++ SDK (build): agonessdk-1.51.0-dev-4403ced-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.51.0-dev-4403ced.zip

A preview of the website (the last 30 builds are retained):

https://4403ced-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4216/head:pr_4216 && git checkout pr_4216
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.51.0-dev-4403ced

markmandel

Sweeeeeet!

We'll need some docs here: https://agones.dev/site/docs/guides/client-sdks/unreal/

But make sure the new docs are wrapped in a feature shortcode: https://agones.dev/site/docs/contribute/documentation-editing-contribution/

I am going to call on past unreal contributors, if you wouldn't mind reviewing if possible:
@alexrudd, @KAllan357, @GloryOfNight, @KiaArmani, @DevChagrins - if one of you could take a look at these code changes and make sure they are good?

keith-miller · 2025-07-13T23:31:17Z

Sure thing! Will work on the docs and get those in.

keith-miller · 2025-07-21T01:38:39Z

@markmandel hey, so I see the game engine client SDKs reference List actions that don't match the REST section (I was using the REST docs to implement the Unreal functionality). I'm assuming the REST section is out of date, but maybe it's the other way around. Is there a breakdown on the changes so I can get the Unreal functionality up to date?

Thanks

0xaravindh · 2025-07-21T04:58:00Z

/gcbrun

agones-bot · 2025-07-21T05:31:25Z

Build Failed 😭

Build Id: 019fcec5-caee-42ae-9cb1-32eb34553461

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

keith-miller · 2025-07-21T19:25:47Z

Ok, it looks like some of those list methods in other SDKs and they are using Protobuf Fieldmasks and I'm not sure if that exists using regular old HTTP. Just let me know if matching the REST functionality list is ok for Unreal.

0xaravindh · 2025-07-22T04:44:45Z

/gcbrun

agones-bot · 2025-07-22T05:42:42Z

Build Succeeded 🥳

Build Id: af8e6190-0074-4aa7-8b91-0efdf0c61316

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.51.0-dev-c784b78
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.51.0-dev-c784b78
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.51.0-dev-c784b78-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.51.0-dev-c784b78
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.51.0-dev-c784b78
Linux C++ SDK (build): agonessdk-1.51.0-dev-c784b78-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.51.0-dev-c784b78.zip

A preview of the website (the last 30 builds are retained):

https://c784b78-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4216/head:pr_4216 && git checkout pr_4216
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.51.0-dev-c784b78

markmandel · 2025-07-23T00:25:35Z

@markmandel hey, so I see the game engine client SDKs reference List actions that don't match the REST section (I was using the REST docs to implement the Unreal functionality). I'm assuming the REST section is out of date, but maybe it's the other way around. Is there a breakdown on the changes so I can get the Unreal functionality up to date?

Let me know if I'm understanding correctly.

All the other language SDKs (e.g. node, go, etc) use gRPC for their SDK implementations. The engine SDKs use the REST (And some websocket) APIs to implement the Agones integration.

The REST API was primarily built for game engines, since gRPC is game engines is... painful 😱 .

So if you are asking "should I be using the REST API here" - then the answer is yes 👍🏻

markmandel · 2025-07-23T00:25:57Z

/gcbrun

keith-miller · 2025-07-23T01:10:48Z

Oh, believe me, I know :) I would love to have gRPC support in Unreal, but that would be a herculean effort with all the platforms they support. I will update the Agones Unreal SDK docs to match the REST API ones, since the functionality matches.

Thanks!

agones-bot · 2025-07-23T01:28:15Z

Build Failed 😭

Build Id: d729a3ee-23a3-4df2-a509-f509b97023cd

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

0xaravindh · 2025-07-23T05:02:11Z

/gcbrun

agones-bot · 2025-07-23T05:32:51Z

Build Failed 😭

Build Id: 5c588bc8-9ea3-4834-9dc1-dd2a458a59e5

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

0xaravindh · 2025-07-23T14:35:30Z

/gcbrun

GloryOfNight · 2025-07-23T14:41:42Z

LGTM 👍

agones-bot · 2025-07-23T15:33:26Z

Build Succeeded 🥳

Build Id: a413fa44-fce8-4e84-8428-a6588b2728c0

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.51.0-dev-8412ea3
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.51.0-dev-8412ea3
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.51.0-dev-8412ea3-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.51.0-dev-8412ea3
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.51.0-dev-8412ea3
Linux C++ SDK (build): agonessdk-1.51.0-dev-8412ea3-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.51.0-dev-8412ea3.zip

A preview of the website (the last 30 builds are retained):

https://8412ea3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4216/head:pr_4216 && git checkout pr_4216
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.51.0-dev-8412ea3

igooch · 2025-07-28T17:18:40Z

@keith-miller we're about to cut a release. If you need this in for this release, could you please add the short codes to the docs ASAP? This keeps the static version of our site for version 1.50 correctly showing that this isn't implemented.

{{% feature expiryVersion="1.51.0" %}}
existing documentation
{{% /feature %}}

{{% feature publishVersion="1.51.0" %}}
new documentation
{{% /feature %}}

keith-miller · 2025-07-28T17:24:09Z

Sure thing! - Keith

…

On Mon, Jul 28, 2025 at 10:19 AM igooch ***@***.***> wrote: *igooch* left a comment (agones-dev/agones#4216) <#4216 (comment)> @keith-miller <https://github.com/keith-miller> we're about to cut a release. If you need this in for this release, could you please add the short codes to the docs ASAP? This keeps the static version of our site for version 1.50 correctly showing that this isn't implemented. {{% feature expiryVersion="1.51.0" %}} existing documentation {{% /feature %}} {{% feature publishVersion="1.51.0" %}} new documentation {{% /feature %}} — Reply to this email directly, view it on GitHub <#4216 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGAHCW7DDDWBFK3FKOJWDT3KZLQNAVCNFSM6AAAAACBCGWRBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCMRYGIZDQOJUGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

0xaravindh · 2025-07-29T08:22:39Z

/gcbrun

igooch

LGTM per #4216 (comment)

Sivasankaran25 · 2025-07-30T21:08:28Z

/gcbrun

agones-bot · 2025-07-30T21:21:20Z

Build Failed 😭

Build Id: a88a9bf3-ad1f-497f-b11d-4ecdf6b13204

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

igooch · 2025-07-30T21:40:21Z

/gcbrun

agones-bot · 2025-07-30T22:53:41Z

Build Succeeded 🥳

Build Id: 5f59d7c0-7d29-4420-b276-2fd5c8118759

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.51.0-dev-f5e36aa
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.51.0-dev-f5e36aa
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.51.0-dev-f5e36aa-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.51.0-dev-f5e36aa
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.51.0-dev-f5e36aa
Linux C++ SDK (build): agonessdk-1.51.0-dev-f5e36aa-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.51.0-dev-f5e36aa.zip

A preview of the website (the last 30 builds are retained):

https://f5e36aa-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4216/head:pr_4216 && git checkout pr_4216
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.51.0-dev-f5e36aa

keith-miller and others added 3 commits June 25, 2025 11:39

Add support for lists in Unreal SDK, resolves agones-dev#4029

8fb35a4

Some doc and path fixes

af2bf0a

Merge branch 'googleforgames:main' into main

168033a

github-actions bot added kind/feature New features for Agones size/M labels Jul 8, 2025

Merge branch 'main' into main

4403ced

markmandel reviewed Jul 13, 2025

View reviewed changes

keith-miller added 2 commits July 18, 2025 08:44

Merge branch 'googleforgames:main' into main

d1b525f

Merge branch 'googleforgames:main' into main

c784b78

Merge branch 'main' into main

4bf7437

keith-miller added 2 commits July 22, 2025 18:14

Update Unreal SDK docs to show lists are supported

753d230

Merge branch 'main' of github.com:keith-miller/agones

8412ea3

keith-miller and others added 2 commits July 28, 2025 11:17

Wrapping Unreal SDK doc update in a feature check

e7d6800

Merge branch 'main' into main

33b016a

igooch approved these changes Jul 29, 2025

View reviewed changes

markmandel approved these changes Jul 30, 2025

View reviewed changes

Merge branch 'main' into main

a630c19

igooch enabled auto-merge (squash) July 30, 2025 21:24

Merge branch 'main' into main

f5e36aa

igooch merged commit ee750b0 into agones-dev:main Jul 30, 2025
4 checks passed

Conversation

keith-miller commented Jul 8, 2025

Uh oh!

markmandel commented Jul 12, 2025

Uh oh!

agones-bot commented Jul 12, 2025

Uh oh!

markmandel left a comment

Choose a reason for hiding this comment

Uh oh!

keith-miller commented Jul 13, 2025

Uh oh!

keith-miller commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xaravindh commented Jul 21, 2025

Uh oh!

agones-bot commented Jul 21, 2025

Uh oh!

keith-miller commented Jul 21, 2025

Uh oh!

0xaravindh commented Jul 22, 2025

Uh oh!

agones-bot commented Jul 22, 2025

Uh oh!

markmandel commented Jul 23, 2025

Uh oh!

markmandel commented Jul 23, 2025

Uh oh!

keith-miller commented Jul 23, 2025

Uh oh!

agones-bot commented Jul 23, 2025

Uh oh!

0xaravindh commented Jul 23, 2025

Uh oh!

agones-bot commented Jul 23, 2025

Uh oh!

0xaravindh commented Jul 23, 2025

Uh oh!

GloryOfNight commented Jul 23, 2025

Uh oh!

agones-bot commented Jul 23, 2025

Uh oh!

igooch commented Jul 28, 2025

Uh oh!

keith-miller commented Jul 28, 2025 via email

Uh oh!

0xaravindh commented Jul 29, 2025

Uh oh!

igooch left a comment

Choose a reason for hiding this comment

Uh oh!

Sivasankaran25 commented Jul 30, 2025

Uh oh!

agones-bot commented Jul 30, 2025

Uh oh!

igooch commented Jul 30, 2025

Uh oh!

agones-bot commented Jul 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

keith-miller commented Jul 21, 2025 •

edited

Loading