Don't get out of sync when background task creates new init/result#386
Merged
benbrandt merged 2 commits intoagentclientprotocol:mainfrom Mar 9, 2026
Merged
Don't get out of sync when background task creates new init/result#386benbrandt merged 2 commits intoagentclientprotocol:mainfrom
benbrandt merged 2 commits intoagentclientprotocol:mainfrom
Conversation
SteffenDE
added a commit
to SteffenDE/claude-code-acp
that referenced
this pull request
Mar 9, 2026
Relates to agentclientprotocol#386. Relates to agentclientprotocol#336.
SteffenDE
added a commit
to SteffenDE/claude-code-acp
that referenced
this pull request
Mar 9, 2026
Relates to agentclientprotocol#386. Relates to agentclientprotocol#336.
benbrandt
added a commit
that referenced
this pull request
Mar 9, 2026
benbrandt
added a commit
that referenced
this pull request
Mar 9, 2026
benbrandt
pushed a commit
that referenced
this pull request
Mar 13, 2026
…ry 2) (#400) Followup for #386. When sending `/compact`, there's no replay for the user message, so we did not resolve the prompt. Same for `/context`. I tried what happens when sending a `/context` or `/compact` while another prompt is running and Claude does not properly handle it. Instead, it responds with something like > I also noticed you sent /compact while I was working. That's a built-in CLI command (not a skill), which compacts the conversation context. It should be invoked directly in the CLI rather than as a message to me. The important part is f52f214.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #336.
This does NOT ensure that the results are immediately sent to the client.
See #336 (comment).
I guess some tests for this would be useful.