model-viewer: fixes #5316 left controller not visible in AR mode#5317
Merged
dmarcos merged 1 commit intoaframevr:masterfrom Jun 22, 2023
Merged
Conversation
|
hi, con que tema ate referis
El mié, 21 jun 2023 a la(s) 23:36, Doug Reeder ***@***.***)
escribió:
… *Description:*
Left controller is not visible in AR mode
*Changes proposed:*
Typo fixed, now left controller is visible in AR mode
------------------------------
You can view, comment on, or merge this pull request online at:
#5317
Commit Summary
- 475ad12
<475ad12>
model-viewer: fixes #5316 left controller not visible in AR mode
File Changes
(1 file <https://github.com/aframevr/aframe/pull/5317/files>)
- *M* examples/showcase/model-viewer/model-viewer.js
<https://github.com/aframevr/aframe/pull/5317/files#diff-612ddc47633cf2f8cb084ffa1c3e2b8d1cddd0a02ed96afce364275d2d481439>
(2)
Patch Links:
- https://github.com/aframevr/aframe/pull/5317.patch
- https://github.com/aframevr/aframe/pull/5317.diff
—
Reply to this email directly, view it on GitHub
<#5317>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5B3MSHNECKUE6XCOBIFN3LXMOVSBANCNFSM6AAAAAAZPRXHEY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Contributor
Author
|
The issue can be seen in https://aframe.io/aframe/examples/showcase/model-viewer/ |
Member
|
Thanks so much! stupid mistake. The model viewer was developed for magic window AR and it seems not QAed enough for headsets (AR in headsets didn't exist at the time) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Left controller is not visible in AR mode
Changes proposed:
Typo fixed, now left controller is visible in AR mode