feat(rules): separate Feature Implementation Workflow from git-workflow.md (fixes #235) by pangerlkr · Pull Request #278 · affaan-m/ECC

pangerlkr · 2026-02-24T08:13:02Z

Description

Resolves #235

Splits the Feature Implementation Workflow out of rules/common/git-workflow.md into a new dedicated rules/common/development-workflow.md file.

Changes

rules/common/git-workflow.md: Removed the Feature Implementation Workflow section; now focuses exclusively on git-specific concerns (commit message format, PR workflow). Added a reference to the new development-workflow.md.
rules/common/development-workflow.md (new file): Contains the Feature Implementation Workflow (Plan First → TDD → Code Review → Commit & Push), with cross-reference back to git-workflow.md for commit format.

Type of Change

refactor: Code refactoring (moving content between files)
feat: New feature (new file development-workflow.md)

Summary by CodeRabbit

Documentation
- Introduced comprehensive feature development workflow documentation detailing a structured four-step process: planning with task breakdown, test-driven development with coverage targets, code review procedures, and commit practices aligned with conventional standards.
- Reorganized development guidance for improved clarity and streamlined reference across workflow documentation.

…low.md (refs affaan-m#235) Removed the Feature Implementation Workflow section from the Git Workflow document.

…Workflow (refs affaan-m#235) This document outlines the full feature development process, including planning, TDD, code review, and committing to git.

coderabbitai · 2026-02-24T08:13:50Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between db27ba1 and 253aecb.

📒 Files selected for processing (2)

rules/common/development-workflow.md
rules/common/git-workflow.md

📝 Walkthrough

Walkthrough

The PR separates feature development workflow documentation from git-specific workflow concerns by extracting the four-step feature implementation process (Plan, TDD, Code Review, Commit) into a dedicated development-workflow.md file and consolidating git-workflow.md to focus exclusively on git-related operations with a reference to the new document.

Changes

Cohort / File(s)	Summary
Documentation Refactoring `rules/common/git-workflow.md`	Removed "Feature Implementation Workflow" section (23 lines) and replaced with a reference note directing readers to the new development-workflow.md for the complete development process.
New Development Documentation `rules/common/development-workflow.md`	Created new file documenting the feature implementation workflow in four phases: Plan First (using planner agent), TDD Approach (RED-GREEN-REFACTOR-IMPROVE cycle with 80%+ coverage), Code Review (priority-based issue handling), and Commit & Push (conventional commit practices).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 whiskers wiggle with delight
Documentation scattered, now organized right—
Git keeps its workflow, clean and true,
Development gets its own stage too! ✨
A rabbit's joy: concerns separated through and through!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title clearly summarizes the main change: separating the Feature Implementation Workflow from git-workflow.md, which is the primary objective of this changeset.
Linked Issues check	✅ Passed	The pull request fulfills all coding requirements from issue `#235`: it separates the Feature Implementation Workflow into a new development-workflow.md file and refocuses git-workflow.md on git-specific concerns.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to issue `#235`; the PR only modifies git-workflow.md and creates development-workflow.md with no extraneous modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This PR resolves #235 by separating the general Feature Implementation Workflow from the git-focused guidance, keeping git-workflow.md narrowly scoped to git/PR concerns and moving development-process guidance into a new dedicated document.

Changes:

Removed the “Feature Implementation Workflow” section from rules/common/git-workflow.md and added a reference to the new doc.
Added rules/common/development-workflow.md containing the Feature Implementation Workflow and a cross-reference back to git-workflow.md.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
rules/common/git-workflow.md	Removes non-git development-process guidance and links to the new development workflow doc.
rules/common/development-workflow.md	New doc housing the end-to-end feature implementation workflow with a link back to git workflow details.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-24T08:15:44Z

-4. **Commit & Push**
-   - Detailed commit messages
-   - Follow conventional commits format
+> For the full development process (planning, TDD, code review) before git operations,


The phrase "before git operations" is inaccurate now that the referenced development workflow includes a "Commit & Push" step (i.e., git operations). Consider rewording to something like "for the broader development process (planning, TDD, code review) that complements this git workflow" to avoid a contradiction.

Suggested change

> For the full development process (planning, TDD, code review) before git operations,

> For the broader development process (planning, TDD, code review) that complements this git workflow,

Copilot · 2026-02-24T08:15:45Z

+> This file extends [common/git-workflow.md](./git-workflow.md) with the full feature development process that happens before git operations.
+
+The Feature Implementation Workflow describes the development pipeline: planning, TDD, code review, and then committing to git.


This intro says the workflow "happens before git operations", but the file later includes "Commit & Push" which is a git operation. Reword the intro to avoid the internal inconsistency (e.g., describe it as the end-to-end development workflow including committing/pushing).

Suggested change

> This file extends [common/git-workflow.md](./git-workflow.md) with the full feature development process that happens before git operations.

The Feature Implementation Workflow describes the development pipeline: planning, TDD, code review, and then committing to git.

> This file extends [common/git-workflow.md](./git-workflow.md) with the end-to-end feature development process, from planning through commit and push.

The Feature Implementation Workflow describes the end-to-end development pipeline: planning, TDD, code review, and then committing and pushing to git.

Copilot · 2026-02-24T08:15:45Z

+> This file extends [common/git-workflow.md](./git-workflow.md) with the full feature development process that happens before git operations.
+
+The Feature Implementation Workflow describes the development pipeline: planning, TDD, code review, and then committing to git.


The rules index in rules/README.md enumerates the files under rules/common/, but it doesn't include this new development-workflow.md. To keep the documentation consistent/discoverable, update the index to include the new file (and possibly clarify the separation between development vs git workflow).

Suggested change

> This file extends [common/git-workflow.md](./git-workflow.md) with the full feature development process that happens before git operations.

The Feature Implementation Workflow describes the development pipeline: planning, TDD, code review, and then committing to git.

> This file complements [common/git-workflow.md](./git-workflow.md) by describing the feature implementation steps that happen **before** any git branching, committing, or PR activity.

The Feature Implementation Workflow covers the development pipeline (planning, TDD, code review) up to the point where changes are ready to be committed, while `git-workflow.md` documents how to manage branches, commits, and pull requests.

affaan-m

Automated review: doc-only changes look good. Approving.

…ent-workflow-235 feat(rules): separate Feature Implementation Workflow from git-workflow.md (fixes affaan-m#235)

pangerlkr added 2 commits February 24, 2026 13:41

refactor(rules): split Feature Implementation Workflow from git-workf…

946f2ca

…low.md (refs affaan-m#235) Removed the Feature Implementation Workflow section from the Git Workflow document.

feat(rules): add development-workflow.md with Feature Implementation …

253aecb

…Workflow (refs affaan-m#235) This document outlines the full feature development process, including planning, TDD, code review, and committing to git.

Copilot AI review requested due to automatic review settings February 24, 2026 08:13

Copilot started reviewing on behalf of pangerlkr February 24, 2026 08:13 View session

pangerlkr mentioned this pull request Feb 24, 2026

Separate Feature Implementation Workflow from git-workflow.md #235

Closed

Copilot AI reviewed Feb 24, 2026

View reviewed changes

affaan-m approved these changes Feb 24, 2026

View reviewed changes

affaan-m merged commit 5dad143 into affaan-m:main Feb 24, 2026
41 of 42 checks passed

coderabbitai Bot mentioned this pull request Mar 6, 2026

docs(zh-CN): sync Chinese docs with latest upstream changes #341

Merged

11 tasks

This was referenced Mar 22, 2026

Add Turkish (tr) docs and update README #744

Merged

Add Kiro steering files, hooks, and scripts (4/4) #812

Merged

docs: add comprehensive Skill Development Guide #929

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(rules): separate Feature Implementation Workflow from git-workflow.md (fixes #235)#278

feat(rules): separate Feature Implementation Workflow from git-workflow.md (fixes #235)#278
affaan-m merged 2 commits into
affaan-m:mainfrom
pangerlkr:feat/separate-development-workflow-235

pangerlkr commented Feb 24, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Feb 24, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 24, 2026

Uh oh!

Copilot AI Feb 24, 2026

Uh oh!

Copilot AI Feb 24, 2026

Uh oh!

affaan-m left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	> For the full development process (planning, TDD, code review) before git operations,
	> For the broader development process (planning, TDD, code review) that complements this git workflow,

		> This file extends [common/git-workflow.md](./git-workflow.md) with the full feature development process that happens before git operations.

		The Feature Implementation Workflow describes the development pipeline: planning, TDD, code review, and then committing to git.

Uh oh!

Conversation

pangerlkr commented Feb 24, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Type of Change

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

affaan-m left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pangerlkr commented Feb 24, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Feb 24, 2026 •

edited

Loading