scripts/hooks/post-edit-format.js (2)

36-60: detectFormatter misses two valid Prettier config locations

1. package.json "prettier" key — a commonly used inline Prettier config that the detection loop skips entirely.
2. Workspace-level configs in monorepos — detection only runs against the directory containing the nearest package.json. If biome.json or .prettierrc lives at the workspace root (one level above the package), it won't be found. Extending the check to walk up from projectRoot until a formatter config is found (mirroring how findProjectRoot walks up for package.json) would cover this gap.

♻️ Proposed fix: add `package.json` prettier-key check

 function detectFormatter(projectRoot) {
   const biomeConfigs = ['biome.json', 'biome.jsonc'];
   for (const cfg of biomeConfigs) {
     if (fs.existsSync(path.join(projectRoot, cfg))) return 'biome';
   }

   const prettierConfigs = [
     '.prettierrc',
     '.prettierrc.json',
     '.prettierrc.js',
     '.prettierrc.cjs',
     '.prettierrc.mjs',
     '.prettierrc.yml',
     '.prettierrc.yaml',
     '.prettierrc.toml',
     'prettier.config.js',
     'prettier.config.cjs',
     'prettier.config.mjs',
   ];
   for (const cfg of prettierConfigs) {
     if (fs.existsSync(path.join(projectRoot, cfg))) return 'prettier';
   }
+
+  // Check package.json for an inline "prettier" key
+  const pkgPath = path.join(projectRoot, 'package.json');
+  if (fs.existsSync(pkgPath)) {
+    try {
+      const pkg = JSON.parse(fs.readFileSync(pkgPath, 'utf8'));
+      if (pkg.prettier) return 'prettier';
+    } catch {}
+  }

   return null;
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@scripts/hooks/post-edit-format.js` around lines 36 - 60, detectFormatter
currently only checks local biomeConfigs and prettierConfigs files and doesn't
detect a "prettier" key inside package.json nor search parent directories;
update detectFormatter to (1) when scanning for Prettier, also read package.json
at the current directory and return 'prettier' if it contains a "prettier" key,
and (2) instead of only checking projectRoot, walk up parent directories (like
findProjectRoot does) until filesystem root to look for biomeConfigs,
prettierConfigs and package.json "prettier" key so workspace-level configs are
detected; keep the existing return values ('biome' or 'prettier') and null
fallback.

---

78-90: Relative filePath passed to formatter causes silent failures when projectRoot differs from process CWD

Line 80 resolves the path to locate projectRoot, but the original (potentially relative) filePath is passed to getFormatterCommand on line 82. When execFileSync runs with cwd: projectRoot, a relative path is resolved against projectRoot—not the process CWD—targeting the wrong path.

Example (monorepo, process CWD = /workspace):

• filePath: packages/app/src/index.ts (relative)
• projectRoot: /workspace/packages/app
• Formatter receives: prettier --write packages/app/src/index.ts with cwd=/workspace/packages/app
• Effective path: /workspace/packages/app/packages/app/src/index.ts ❌

Similar defensive path resolution is already used in post-edit-typecheck.js (line 32), confirming that relative paths need handling.

♻️ Proposed fix: resolve filePath once and use it throughout

     if (filePath && /\.(ts|tsx|js|jsx)$/.test(filePath)) {
       try {
-        const projectRoot = findProjectRoot(path.dirname(path.resolve(filePath)));
+        const absFilePath = path.resolve(filePath);
+        const projectRoot = findProjectRoot(path.dirname(absFilePath));
         const formatter = detectFormatter(projectRoot);
-        const cmd = getFormatterCommand(formatter, filePath);
+        const cmd = getFormatterCommand(formatter, absFilePath);

         if (cmd) {
           execFileSync(cmd.bin, cmd.args, {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@scripts/hooks/post-edit-format.js` around lines 78 - 90, The formatter is
being passed the original (possibly relative) filePath which, when execFileSync
runs with cwd set to projectRoot, causes wrong paths; resolve filePath to an
absolute path once (e.g., using path.resolve with the original filePath) after
computing projectRoot (or immediately) and then use that resolvedFilePath for
getFormatterCommand, for any args passed to execFileSync, and anywhere else
filePath is used (references: filePath, projectRoot, findProjectRoot,
detectFormatter, getFormatterCommand, execFileSync) so the formatter always
receives an absolute correct path.