fix: plugin hooks no-op on Node 21+ (require.main undefined under -e) + green the suite#2184
Merged
Conversation
…rn Node ROOT CAUSE: hooks load plugin-hook-bootstrap.js via `node -e "...; process.argv.splice(1,0,s); require(s)"`. On Node 21+, require.main is `undefined` under --eval, so the `if (require.main === module)` guard was false and main() never ran — every plugin hook silently no-op'd (e.g. the MCP-health PreToolUse hook stopped blocking). CI (Node 18/20) hid this; it only surfaces on Node 21+. Fix: also run main() when require.main is undefined (the eval-bootstrap case), while staying dormant on real imports. Also clears pre-existing main debt the full local suite enforces: - catalog:sync — README/docs agent+skill counts drifted after recent merges - tests/ci/supply-chain-watch-workflow: update checkout SHA to the merged v6.0.3 (#2183) - markdownlint + check-unicode-safety --write across docs/skills Suite: 2683/2683 green under Node v25; lint + unicode clean.
Contributor
|
ECC bundle files are already tracked in this repository. Skipping generation of another bundle PR. |
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (36)
📝 WalkthroughWalkthroughThis PR updates the ECC plugin catalog inventory from 63/251 to 64/255 agents/skills across manifests and documentation, fixes plugin hook bootstrap execution for eval/Node 21+ loading paths, and applies extensive whitespace and formatting normalization across skill and documentation files. ChangesCatalog inventory count updates
Plugin hook bootstrap execution fix
Documentation and skill file formatting normalization
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
syarfandi
pushed a commit
to syarfandi/ECC
that referenced
this pull request
Jun 9, 2026
…rn Node (affaan-m#2184) ROOT CAUSE: hooks load plugin-hook-bootstrap.js via `node -e "...; process.argv.splice(1,0,s); require(s)"`. On Node 21+, require.main is `undefined` under --eval, so the `if (require.main === module)` guard was false and main() never ran — every plugin hook silently no-op'd (e.g. the MCP-health PreToolUse hook stopped blocking). CI (Node 18/20) hid this; it only surfaces on Node 21+. Fix: also run main() when require.main is undefined (the eval-bootstrap case), while staying dormant on real imports. Also clears pre-existing main debt the full local suite enforces: - catalog:sync — README/docs agent+skill counts drifted after recent merges - tests/ci/supply-chain-watch-workflow: update checkout SHA to the merged v6.0.3 (affaan-m#2183) - markdownlint + check-unicode-safety --write across docs/skills Suite: 2683/2683 green under Node v25; lint + unicode clean. Co-authored-by: ECC Test <ecc@example.test>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Plugin hooks load
plugin-hook-bootstrap.jsvianode -e "...; process.argv.splice(1,0,s); require(s)". On Node 21+,require.mainisundefinedunder--eval, so theif (require.main === module)guard was false andmain()never ran — every plugin hook silently no-op'd (e.g. the MCP-health PreToolUse hook stopped blocking unhealthy MCP calls). CI runs Node 18/20 where the trick still works, which is why this stayed hidden; it only surfaces on Node 21+.Fix: also run
main()whenrequire.mainisundefined(the eval-bootstrap case), while staying dormant on realrequire()imports (tests) whererequire.mainis a defined, different module.Also clears pre-existing main debt the full local suite enforces
catalog:sync— README/docs agent+skill counts had drifted after recent mergestests/ci/supply-chain-watch-workflow: update checkout SHA to the merged v6.0.3 (chore(deps): bump actions/checkout from 6.0.2 to 6.0.3 #2183)markdownlint --fix+check-unicode-safety --writeacross docs/skillsVerification
Full suite 2683/2683 green under Node v25; lint + unicode clean. (Was 4 failures on Node 25 before.)
Summary by cubic
Fixes plugin hooks no-op on Node 21+ by running
main()whenrequire.mainis undefined undernode --eval; hooks now execute correctly while staying dormant on imports. Also greens the suite on Node 25, syncs agent/skill counts in docs, pinsactions/checkoutto v6.0.3, and applies markdown/unicode cleanup.Written for commit 44da898. Summary will update on new commits.
Summary by CodeRabbit
Chores
Bug Fixes
Documentation