Skip to content

fix: truncate corrupted legacy command shims#2167

Merged
affaan-m merged 1 commit into
affaan-m:mainfrom
Spartallan:fix/truncate-legacy-shims
Jun 7, 2026
Merged

fix: truncate corrupted legacy command shims#2167
affaan-m merged 1 commit into
affaan-m:mainfrom
Spartallan:fix/truncate-legacy-shims

Conversation

@konstapukarifastnetfi

@konstapukarifastnetfi konstapukarifastnetfi commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

What Changed

Three files under legacy-command-shims/commands/ still carried their full pre-shim command bodies concatenated below the shim header, including stray closing braces, orphaned code fences, and content from an unrelated project:

  • tdd.md: kept lines 1-23 (shim header + delegation), deleted the 208 leftover lines
  • e2e.md: kept lines 1-23, deleted the 245 leftover lines
  • orchestrate.md: kept lines 1-24, deleted the 111 leftover lines

Pure deletions; each file now ends cleanly after its Delegation section like the nine other shims in the directory.

Why This Change

The legacy shims are supposed to be thin pointers to the skill equivalents. The leftover bodies ship broken markdown (unbalanced fences, dangling }) and stale instructions that contradict the skill the shim delegates to, and they load into context on every install that includes the shims.

Testing Done

  • Manual testing completed - surviving headers verified structurally identical to the nine untouched reference shims; each file ends with a POSIX newline
  • Automated tests pass locally (node tests/run-all.js) - full suite 2619/2619 in a clean Linux container (node:22-bookworm, fresh npm ci)
  • Edge cases considered and tested - translation/docs copies checked: locale command docs are independent localized documents, not copies of these shims; no mirrors needed syncing

Type of Change

  • fix: Bug fix

Security & Quality Checklist

  • No secrets or API keys committed (ghp_, sk-, AKIA, xoxb, xoxp patterns checked)
  • JSON files validate cleanly
  • Shell scripts pass shellcheck (if applicable)
  • Pre-commit hooks pass locally (if configured)
  • No sensitive data exposed in logs or output
  • Follows conventional commits format

Documentation

  • Updated relevant documentation - n/a, deletions only
  • Added comments for complex logic - n/a
  • README updated (if needed) - n/a

Summary by cubic

Truncated legacy-command-shims/commands/tdd.md, e2e.md, and orchestrate.md so they end cleanly after Delegation. Removes corrupted leftover content to prevent broken markdown and stale guidance from loading into context.

Written for commit 252c2bb. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Documentation
    • Cleaned up end-to-end command documentation by removing legacy test examples.
    • Enhanced orchestration command guidance with updated delegation instructions for improved clarity.
    • Refined test-driven development command documentation to ensure core guidance is clearly presented.

tdd.md, e2e.md, and orchestrate.md in legacy-command-shims/commands/ still
carried their full pre-shim command bodies concatenated below the shim
headers: a stray '})' and orphaned code fence in tdd.md, leftover Playwright
test bodies plus a foreign project-specific 'PMX-Specific Critical Flows'
section in e2e.md, and orphaned report-template fragments in orchestrate.md.
The trailing bodies also contradicted the shim headers by claiming the
commands invoke agents directly.

Truncate each file at the end of its Delegation section. The other nine
legacy shims are clean 20-23 line shims and are untouched.
@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Linter diff in the way? Review this PR in Change Stack to focus on meaningful changes and expand context only when needed.

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 86258959-3dd8-4501-a0c4-f1e0a63144e4

📥 Commits

Reviewing files that changed from the base of the PR and between 7113b5b and 252c2bb.

📒 Files selected for processing (3)
  • legacy-command-shims/commands/e2e.md
  • legacy-command-shims/commands/orchestrate.md
  • legacy-command-shims/commands/tdd.md
💤 Files with no reviewable changes (3)
  • legacy-command-shims/commands/tdd.md
  • legacy-command-shims/commands/orchestrate.md
  • legacy-command-shims/commands/e2e.md

📝 Walkthrough

Walkthrough

This PR updates documentation across three legacy command shim files. The orchestrate.md delegation section is replaced with explicit skill sequencing guidance. The tdd.md delegation guidance is preserved while legacy markup is removed. The e2e.md file removes embedded test code examples without replacement.

Changes

Legacy Command Shim Documentation Cleanup

Layer / File(s) Summary
Orchestrate skill delegation guidance
legacy-command-shims/commands/orchestrate.md
The delegation section is expanded with explicit sequencing guidance for dmux-workflows and autonomous-agent-harness skills, replacing the legacy "Security Reviewer" status template.
TDD skill delegation guidance cleanup
legacy-command-shims/commands/tdd.md
Core TDD delegation bullets (RED→GREEN→REFACTOR strictness and tests-first guidance) are preserved and repositioned cleanly, with surrounding legacy markup removed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes


🐰 These docs hop into focus, so clean!
Old templates out, new guidance now seen,
Legacy artifacts swept away with care,
Skills delegate true, with purpose laid bare.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing corrupted content from three legacy command shim files to restore their intended thin-delegation structure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Re-trigger cubic

@affaan-m affaan-m merged commit be536c1 into affaan-m:main Jun 7, 2026
3 checks passed
syarfandi pushed a commit to syarfandi/ECC that referenced this pull request Jun 9, 2026
tdd.md, e2e.md, and orchestrate.md in legacy-command-shims/commands/ still
carried their full pre-shim command bodies concatenated below the shim
headers: a stray '})' and orphaned code fence in tdd.md, leftover Playwright
test bodies plus a foreign project-specific 'PMX-Specific Critical Flows'
section in e2e.md, and orphaned report-template fragments in orchestrate.md.
The trailing bodies also contradicted the shim headers by claiming the
commands invoke agents directly.

Truncate each file at the end of its Delegation section. The other nine
legacy shims are clean 20-23 line shims and are untouched.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants