fix: truncate corrupted legacy command shims#2167
Conversation
tdd.md, e2e.md, and orchestrate.md in legacy-command-shims/commands/ still carried their full pre-shim command bodies concatenated below the shim headers: a stray '})' and orphaned code fence in tdd.md, leftover Playwright test bodies plus a foreign project-specific 'PMX-Specific Critical Flows' section in e2e.md, and orphaned report-template fragments in orchestrate.md. The trailing bodies also contradicted the shim headers by claiming the commands invoke agents directly. Truncate each file at the end of its Delegation section. The other nine legacy shims are clean 20-23 line shims and are untouched.
|
Linter diff in the way? Review this PR in Change Stack to focus on meaningful changes and expand context only when needed. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (3)
📝 WalkthroughWalkthroughThis PR updates documentation across three legacy command shim files. The orchestrate.md delegation section is replaced with explicit skill sequencing guidance. The tdd.md delegation guidance is preserved while legacy markup is removed. The e2e.md file removes embedded test code examples without replacement. ChangesLegacy Command Shim Documentation Cleanup
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
tdd.md, e2e.md, and orchestrate.md in legacy-command-shims/commands/ still carried their full pre-shim command bodies concatenated below the shim headers: a stray '})' and orphaned code fence in tdd.md, leftover Playwright test bodies plus a foreign project-specific 'PMX-Specific Critical Flows' section in e2e.md, and orphaned report-template fragments in orchestrate.md. The trailing bodies also contradicted the shim headers by claiming the commands invoke agents directly. Truncate each file at the end of its Delegation section. The other nine legacy shims are clean 20-23 line shims and are untouched.
What Changed
Three files under
legacy-command-shims/commands/still carried their full pre-shim command bodies concatenated below the shim header, including stray closing braces, orphaned code fences, and content from an unrelated project:tdd.md: kept lines 1-23 (shim header + delegation), deleted the 208 leftover linese2e.md: kept lines 1-23, deleted the 245 leftover linesorchestrate.md: kept lines 1-24, deleted the 111 leftover linesPure deletions; each file now ends cleanly after its Delegation section like the nine other shims in the directory.
Why This Change
The legacy shims are supposed to be thin pointers to the skill equivalents. The leftover bodies ship broken markdown (unbalanced fences, dangling
}) and stale instructions that contradict the skill the shim delegates to, and they load into context on every install that includes the shims.Testing Done
node tests/run-all.js) - full suite 2619/2619 in a clean Linux container (node:22-bookworm, freshnpm ci)Type of Change
fix:Bug fixSecurity & Quality Checklist
Documentation
Summary by cubic
Truncated
legacy-command-shims/commands/tdd.md,e2e.md, andorchestrate.mdso they end cleanly after Delegation. Removes corrupted leftover content to prevent broken markdown and stale guidance from loading into context.Written for commit 252c2bb. Summary will update on new commits.
Summary by CodeRabbit