#112 removed bower as a peer dependency in package.json#136
#112 removed bower as a peer dependency in package.json#136afeld merged 3 commits intoafeld:masterfrom
Conversation
|
LGTM |
|
I added another patch that allows you to run the tests locally - they fail otherwise when you run npm test |
package.json
Outdated
There was a problem hiding this comment.
I would rather change this line to be bower install && grunt rather than making the install grunt task above.
Unless you update the task to only do bower install the first time.
|
Better? |
There was a problem hiding this comment.
These three things should be installed globally, right?
There was a problem hiding this comment.
I imagine bower and grunt-cli should be, but are not guaranteed to be. Having them devDependencies should be safer. Unless they conflict?
Or are you saying, that rather then defining them as devDependencies, instead figure out how to call npm install bower -g?
There was a problem hiding this comment.
Should be fine as dev deps.
There was a problem hiding this comment.
Having them as dev deps allows us to use them in the scripts field without necessarily requiring users install bower and grunt-cli globally.
There was a problem hiding this comment.
I like this way. I don't have bower installed globally, and wouldn't like to.
#112 removed bower as a peer dependency in package.json
|
Also, all our bower dependencies are available on npm, so that could be changed as well at some point. |
|
Any chance we can release v2.0.3 to npm? |
No description provided.