Fix macOS menu role mis-wiring: Preferences opened Shortcuts dialog (#883)#924
Merged
Merged
Conversation
…ethersdr#883) On macOS, Qt auto-assigns PreferencesRole to actions containing setup, setting, or config in their text. This caused Configure Shortcuts to be reparented into the macOS app menu Preferences slot, while the actual settings actions became invisible. Fix by explicitly setting NoRole on all affected actions and adding a dedicated PreferencesRole action that correctly triggers Radio Setup. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
aethersdr-agent Bot
pushed a commit
that referenced
this pull request
Apr 10, 2026
…883) (#924) On macOS, Qt auto-assigns PreferencesRole to actions containing setup, setting, or config in their text. This caused Configure Shortcuts to be reparented into the macOS app menu Preferences slot, while the actual settings actions became invisible. Fix by explicitly setting NoRole on all affected actions and adding a dedicated PreferencesRole action that correctly triggers Radio Setup. Co-authored-by: AetherClaude <aetherclaude@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #883
On macOS, Qt automatically assigns
QAction::PreferencesRoleto any action whose text contains "setup", "setting", or "config". Since no explicitsetMenuRole()calls existed in the codebase, Qt was reparenting the wrong actions into the macOS app menu:AetherSDR → Preferencesopened the Keyboard Shortcuts dialog instead of Radio SetupView → Configure Shortcuts...disappeared from its menu (silently reparented)TX Band Settings...,AetherDSP Settings...) were also orphanedChanges
QAction::NoRoleon all 5 affected actions to prevent macOS auto-reparenting:Radio Setup...(matches "setup")Choose Radio / SmartLink Setup...(matches "setup")TX Band Settings...(matches "setting")AetherDSP Settings...(matches "setting")Configure Shortcuts...(matches "config")PreferencesRoleaction that correctly triggers Radio Setup from the macOS app menuNo behavior change on Linux/Windows — menu roles are ignored on those platforms.
Test plan
AetherSDR → Preferencesopens Radio Setup dialogView → Configure Shortcuts...is visible and opens the shortcut editor🤖 Generated with Claude Code