Skip to content

Revert "shrink-to-fit VFO/RxApplet frequency" (#3839 landed half-baked)#3846

Merged
NF0T merged 1 commit into
aethersdr:mainfrom
jensenpat:revert/3839-half-baked
Jun 26, 2026
Merged

Revert "shrink-to-fit VFO/RxApplet frequency" (#3839 landed half-baked)#3846
NF0T merged 1 commit into
aethersdr:mainfrom
jensenpat:revert/3839-half-baked

Conversation

@jensenpat

Copy link
Copy Markdown
Collaborator

Reverts #3839.

#3839 landed half-baked. It drove the fitted frequency pixel size via QWidget::setFont(), but a QLabel whose stylesheet names font-family makes Qt recompute the font from the QSS on every re-polish and discard setFont(), falling back to the ~13px app default. So the leading digits no longer clip, but the frequency renders unreadably small — the fix is incomplete.

Rather than ship that behavior on main, this reverts it. The complete fix is #3844:

  • the fitted size is applied through the stylesheet as a literal font-size (which always wins over the cascade), so the digits actually render at the intended size;
  • the RX Controls frequency becomes a full-width hero (~34px) with a reorganized control layout.

Reverts cleanly — no commit since #3839 touched the frequency files. Build passes.

💻 Generated with Claude Code (Opus 4.8) with architecture by @jensenpat

…r clip — Principle XI. (aethersdr#3839)"

This reverts commit c66f6fa.

aethersdr#3839 landed half-baked. It drove the fitted frequency pixel size via
QWidget::setFont(), but a QLabel whose stylesheet names font-family makes Qt
recompute the font from the QSS on every re-polish and discard setFont(),
falling back to the ~13px app default. The result: the leading digits no longer
clip, but the frequency renders unreadably small. The fix is incomplete.

Reverting to keep main clean rather than ship the half-baked behavior. The
complete fix — the fitted size applied through the stylesheet as a literal
font-size, plus the RX Controls hero-frequency redesign — is aethersdr#3844.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@jensenpat jensenpat requested a review from a team as a code owner June 26, 2026 23:08
@NF0T

NF0T commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

@NF0T review — PR #3846

Clean mechanical revert of #3839. Merging to keep main clean while #3844 (the complete fix) lands.

The bug in #3839 is real. The FreqLabelFit.h approach dropped font-size from the QSS and drove the pixel size via setFont(), on the empirically stated basis that a QSS without font-size lets setFont() win. That's only partially true: a QLabel with font-family in its QSS causes Qt to recompute the entire font from the QSS on every re-polish (theme change, style event), discarding the prior setFont() value and falling back to the ~13px application default. The initial grab proof appeared correct because the re-polish hadn't fired yet. This is a genuine Qt subtlety — easy to miss, quick to catch in a running app.

The revert is exact. The diff is a clean inverse of commit c66f6fa04 with no extraneous changes. All 5 substantive CI checks pass (build, check-macos, check-windows, a11y, CodeQL quick scan). The deep analyze (cpp) job appears stalled in the queue at 0s duration — a GitHub Actions runner issue, not a code issue; a pure revert has nothing new for CodeQL to flag.

#3844 (the complete fix using a stylesheet-embedded literal font-size) is the right approach and should follow this revert. Merging now.

@NF0T NF0T self-assigned this Jun 26, 2026

@NF0T NF0T left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean inverse of c66f6fa — verified no extraneous changes. 5/6 CI checks green; analyze (cpp) appears queue-stalled at 0s (pure revert, nothing new for CodeQL). Tier 3 only. Merging to restore main while #3844 (complete fix) lands.

@NF0T NF0T merged commit 3b7434a into aethersdr:main Jun 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants