docs(gui): correct stale wireDaxIq() call-site comment (#2530)#3566
Merged
Conversation
The call-site comment said "(no-audio-bridge platforms)", but aethersdr#3522 de-gated wireDaxIq() to wire DAX-IQ routing once at construction on all platforms (the startDax() copy was removed). Update the comment to match. No code change. The helper extraction aethersdr#2530 requested already landed via aethersdr#3351 Phase 2d + aethersdr#3522. Co-authored-by: Don @ cloaked.agency <don@cloaked.agency> & K6OZY
Contributor
There was a problem hiding this comment.
Verified the change against current main — it's an accurate, comment-only fix.
- The call-site comment at
src/gui/MainWindow.cpp:1609did read(no-audio-bridge platforms), which is stale:wireDaxIq()is now invoked unconditionally with no platform#ifgate, so the new wording ("established once at construction for all platforms … de-gated #3522") correctly reflects the actual behavior. - The companion comment your PR references is present at
src/gui/MainWindow_DigitalModes.cpp:976-979("wired ONCE at construction … deliberately NOT wired here"), confirmingstartDax()carries no IQ wiring — so the documentation is now consistent across both sites. - Comment-only, no code or behavior change; nothing to flag on conventions, null-safety, leaks, or error handling.
Nicely scoped and well-evidenced PR description — the cross-references to #3541/#3522 made verification quick. Thanks for cleaning up the residual, @Ozy311. 73
🤖 aethersdr-agent · cost: $3.4916 · model: claude-opus-4-8
G6PWY-Chris
pushed a commit
to G6PWY-Chris/AetherSDR
that referenced
this pull request
Jun 22, 2026
… (aethersdr#3566) Comment-only: the wireDaxIq() call-site comment in the constructor still said '(no-audio-bridge platforms)', stale after aethersdr#3522 made the helper unconditional/all-platforms. Updated to reflect once-at-construction wiring independent of the audio bridge. Closes aethersdr#2530 (the extract-helper request was already resolved by aethersdr#3541 + aethersdr#3522). No code/behaviour change. Co-authored-by: Ozy311 <ozy311@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#2530 asks to extract a
wireDaxIqRouting()helper to collapse the duplicated DAX-IQconnect()wiring that #2524 copied between theMainWindowconstructor andstartDax().That refactor has already landed — the duplication is gone:
MainWindow::wireDaxIq()(src/gui/MainWindow_Session.cpp).startDax()copy and removed the#if !defined(Q_OS_MAC) && !defined(HAVE_PIPEWIRE)gate, so the helper is now called once, unconditionally, on all platforms from the constructor (src/gui/MainWindow.cpp:1611);startDax()carries the "wired ONCE at construction … deliberately NOT wired here" comment and contains zero IQ wiring.So there is nothing left to extract — current
mainalready has the single platform-agnostic helper #2530 asked for (it exists aswireDaxIq, notwireDaxIqRouting).What this PR does
Fixes the one stale residual: the call-site comment above
wireDaxIq();still read "(no-audio-bridge platforms)", which is no longer accurate after #3522. Updated to reflect the all-platforms wiring. Comment-only; no code/behaviour change.Closes #2530.
Test plan
ninja -C buildclean on Linux (Nobara, Qt 6.10.3) — comment-only, no behaviour change.73, Ozy K6OZY
AI compute partnership: cloaked.agency — drafted with Don, our VP of Engineering agent, on the Linux dev stack (
nobara-dell).