fix(radio-setup): wrap tab pages in QScrollArea so tall tabs stay reachable (#3345). Principle III.#3347
Merged
Merged
Conversation
…chable (#3345). Principle III. On small or high-DPI displays the Themes/Audio/Filters/Peripherals tabs stack QGroupBox content taller than the screen; Qt enforces the layout's sizeHint() as the dialog's effective minimum, the frameless title bar goes off-screen, and the Close button becomes unreachable. The bug report shows the Themes tab at ~2147px against a ~1413px screen. Adopt the QScrollArea pattern already used by buildAntennaNamesTab() (src/gui/RadioSetupDialog.cpp:2903-2908) at the two tab-insertion points: the eagerly-built Radio tab and buildDeferredTab(). The new wrapTabInScrollArea() helper uses setWidgetResizable(true) and a transparent frameless QScrollArea, so wide-screen users see no visual change and small-display users get a vertical scrollbar instead of a clipped dialog. The existing setMinimumSize(820, 620) is small enough that the Close button is always reachable once content scrolls, which also resolves the "can't shrink to close" half of the report. Blast radius: risk_score=0.191, 3 high-risk affected (top: MainWindow::MainWindow, MainWindow::wirePanadapter, MainWindow::buildMenuBar). All cited callers construct the dialog or wire it into menus; none inspect tab-content widget hierarchy, so wrapping content in a QScrollArea does not regress them. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2 tasks
jensenpat
approved these changes
Jun 1, 2026
jensenpat
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the net change (RadioSetupDialog.cpp scroll-area wrapping). setWidgetResizable(true) keeps horizontal expansion and hides the scrollbar when content fits, so only over-tall tabs gain scrolling — no change for wide-screen users. QScrollArea ownership is handled by Qt parenting via the tab/layout, comments cite #3345, and the change is scoped to the two tab-insertion sites without touching window chrome or RX flow. Tested locally as part of a combined build. LGTM.
w5jwp
pushed a commit
to w5jwp/AetherSDR
that referenced
this pull request
Jun 2, 2026
Hotfix release on top of v26.6.1, bundling three already-merged fixes and nothing else: - fix(ci): unblock macOS DMG build broken by missing background image (aethersdr#3349) - fix(gui): only toast "Step: …" on deliberate step changes (aethersdr#3337) - fix(radio-setup): wrap tab pages in QScrollArea so tall tabs stay reachable (aethersdr#3347) Bumps project version 26.6.1 -> 26.6.1.1 (CalVer hotfix sub-patch). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
G6PWY-Chris
pushed a commit
to G6PWY-Chris/AetherSDR
that referenced
this pull request
Jun 22, 2026
…chable (aethersdr#3345). Principle III. (aethersdr#3347) ## Summary Fixes aethersdr#3345 ### What was changed fix(radio-setup): wrap tab pages in QScrollArea so tall tabs stay reachable (aethersdr#3345). Principle III. ### Files modified - `src/gui/RadioSetupDialog.cpp` ``` src/gui/RadioSetupDialog.cpp | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) ``` --- Generated by AetherClaude (automated agent for AetherSDR) --- <sub>🤖 aethersdr-agent · cost: $12.8014 · model: claude-opus-4-7</sub> Co-authored-by: aethersdr-agent[bot] <273844287+aethersdr-agent[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3345
What was changed
fix(radio-setup): wrap tab pages in QScrollArea so tall tabs stay reachable (#3345). Principle III.
Files modified
src/gui/RadioSetupDialog.cppGenerated by AetherClaude (automated agent for AetherSDR)
🤖 aethersdr-agent · cost: $12.8014 · model: claude-opus-4-7