ci(windows): attach MSIX/.msixupload to release; document Store automation plan by jensenpat · Pull Request #3281 · aethersdr/AetherSDR

jensenpat · 2026-05-29T21:23:44Z

What

The Windows Installer workflow already builds the .msix and .msixupload
(the Partner Center upload artifact) but only exposed them as workflow
artifacts. This attaches them to the GitHub release alongside the
portable .zip and Inno setup.exe, so each tagged build has the Store
package ready to download for manual Partner Center submission.

Also adds a PLANNED section to docs/WINDOWS-STORE-MSIX.md documenting the
intended msstore-CLI auto-submission path (maintainer-gated draft via
--noCommit), including the free-Entra-tenant setup step required for an
individual (personal-MSA) Partner Center account.

Why

We're approved and live in the Microsoft Store. For now the maintainer
uploads the .msixupload to Partner Center by hand each release; having it on
the release page (not buried in Actions artifacts) makes the weekend release
flow a one-click download. Full auto-submission is scoped to a later PR once
the Entra/Partner Center credentials are set up.

Changes

.github/workflows/windows-installer.yml — add AetherSDR-*.msix and
AetherSDR-*.msixupload to the softprops/action-gh-release file globs.
docs/WINDOWS-STORE-MSIX.md — document the planned automated Store
submission flow and individual-account Entra tenant setup.

Notes / risk

The MSIX packaging step remains continue-on-error: true (deliberate guard
so an MSIX hiccup can't block the established portable-ZIP/Inno delivery).
Consequence: on a build where MSIX packaging fails, the new release globs
match nothing — softprops skips unmatched globs by default rather than
failing the release. Glance at the "Create MSIX package" step log to
confirm the .msixupload was produced before relying on the release asset.
No behavior change to the portable ZIP or Inno installer paths.

🤖 Generated with Claude Code

…ation plan The Windows Installer workflow already builds the .msix and .msixupload (the Partner Center upload artifact) but only exposed them as workflow artifacts. Attach them to the GitHub release alongside the portable .zip and Inno setup.exe so each tagged build has the Store package ready to download for manual Partner Center submission. Also documents the planned msstore-CLI auto-submission path (maintainer- gated draft via --noCommit) in docs/WINDOWS-STORE-MSIX.md, including the free-Entra-tenant setup step required for individual Partner Center accounts. Marked PLANNED — not yet wired. The MSIX packaging step remains continue-on-error, so the new release globs may match nothing on a failed MSIX build; softprops skips unmatched globs rather than failing the release, preserving the established portable-ZIP/Inno delivery path. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

ten9876 · 2026-05-30T03:23:18Z

@AetherClaude review this PR

aethersdr-agent · 2026-05-30T03:24:25Z

Review

Read the diff against .github/workflows/windows-installer.yml and packaging/windows/create-msix.ps1. The core change is sound and the inline comment + risk notes are accurate:

✅ softprops/action-gh-release does skip unmatched globs by default (fail_on_unmatched_files: false), so a failed continue-on-error MSIX step degrades cleanly to the existing ZIP/Inno release — the PR's claim holds.
✅ No behavior change to the portable-ZIP or Inno paths.
✅ The PLANNED doc section is well-scoped (the --noCommit draft gate + the individual-account Entra tenant step are the two things people actually trip on).

One substantive suggestion: don't attach the raw `.msix` to the public release

The workflow invokes packaging with -SkipSign (windows-installer.yml:173), and create-msix.ps1:454 confirms that produces a deliberately unsigned .msix. That's correct for the Partner Center pipeline — the Store re-signs the .msixupload. But it makes the bare .msix a footgun on the public release page: an end user who downloads AetherSDR-*.msix and double-clicks it can't sideload it (Windows refuses an unsigned MSIX with no trusted cert), so it just fails — a likely support-question magnet. The .msixupload is unambiguously a maintainer artifact (it's a zip of the msix + .appxsym, only meaningful to Partner Center), so attaching it is fine.

Consider attaching only the upload package to the release, while keeping both in the upload-artifact step (where the unsigned .msix is still handy for maintainer inspection):

      - name: Attach to release
        if: startsWith(github.ref, 'refs/tags/')
        uses: softprops/action-gh-release@b4309332981a82ec1c5618f44dd2e27cc8bfbfda  # v3
        with:
          # .msixupload is the Partner Center upload artifact (manual Store
          # submission for now — see docs/WINDOWS-STORE-MSIX.md). It's a
          # maintainer-only package; the raw .msix is intentionally left off
          # the public release because CI builds it unsigned (-SkipSign) and
          # an unsigned .msix can't be sideloaded by end users. The MSIX step
          # is continue-on-error, so this glob may match nothing on a failed
          # build; softprops skips unmatched globs rather than failing.
          files: |
            AetherSDR-*.zip
            AetherSDR-*-setup.exe
            AetherSDR-*.msixupload

If you'd rather keep the .msix on the release for transparency, that's a defensible call too — just worth a one-line note in the release body that it's an unsigned Store-pipeline artifact, not an installer.

Everything else looks good to merge.

This is a judgment-call suggestion, not a blocker. A maintainer can authorize the orchestrator to land it by adding the aetherclaude-eligible label (not currently present on this issue).

73, Jeremy KK7GWY & Claude (AI dev partner)

_{🤖 aethersdr-agent · cost: $1.8307 · model: claude-opus-4-8}

Per review (AetherClaude on #3281): the .msix is built unsigned (-SkipSign, the Store re-signs the .msixupload), so an end user who downloads it from the public release page can't sideload it — Windows refuses an unsigned MSIX with no trusted cert. That makes the raw .msix a support-question footgun. Drop it from the release assets, keeping only the maintainer-meaningful .msixupload. The .msix is still produced and retained in the upload-artifact step for maintainer inspection. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

jensenpat · 2026-05-30T06:01:41Z

Applied the review suggestion in d9ceacd: the unsigned raw .msix is no longer attached to the public release — only the maintainer-meaningful .msixupload is. The .msix is still built and retained in the upload-artifact step for maintainer inspection, and the inline comment now explains why it's deliberately off the public release (unsigned -SkipSign build → end users can't sideload it).

No change to the portable-ZIP or Inno installer paths.

@ten9876 ready for re-review when you have a moment — this touches .github/workflows/ so it needs your maintainer approval.

@jensenpat

Release-prep for **v26.6.2**, a consolidated release rolling up the 26.6.1 feature wave, the v26.6.1.1 hotfixes, and new work through #3443. Bumps version 26.6.1.1 → 26.6.2 in `CMakeLists.txt` and the `README.md` banner, and prepends the v26.6.2 `CHANGELOG.md` entry. No code changes. Headline content: runtime theming system, three HID controller classes (StreamDeck+, Ulanzi Dial, Icom RC-28), the packet-radio suite (KISS-over-TCP TNC #3279, connected-mode BBS terminal #3381, PMS mailbox), and the Microsoft Store MSIX packaging path (#3178/#3205/#3225/#3281). 💻 Generated with Claude Code (Opus 4.8) with architecture by @jensenpat Co-authored-by: Codex <noreply@openai.com>

…ation plan (aethersdr#3281) ## What The Windows Installer workflow already builds the `.msix` and `.msixupload` (the Partner Center upload artifact) but only exposed them as **workflow artifacts**. This attaches them to the **GitHub release** alongside the portable `.zip` and Inno `setup.exe`, so each tagged build has the Store package ready to download for manual Partner Center submission. Also adds a `PLANNED` section to `docs/WINDOWS-STORE-MSIX.md` documenting the intended `msstore`-CLI auto-submission path (maintainer-gated draft via `--noCommit`), including the free-Entra-tenant setup step required for an individual (personal-MSA) Partner Center account. ## Why We're approved and live in the Microsoft Store. For now the maintainer uploads the `.msixupload` to Partner Center by hand each release; having it on the release page (not buried in Actions artifacts) makes the weekend release flow a one-click download. Full auto-submission is scoped to a later PR once the Entra/Partner Center credentials are set up. ## Changes - `.github/workflows/windows-installer.yml` — add `AetherSDR-*.msix` and `AetherSDR-*.msixupload` to the `softprops/action-gh-release` file globs. - `docs/WINDOWS-STORE-MSIX.md` — document the planned automated Store submission flow and individual-account Entra tenant setup. ## Notes / risk - The MSIX packaging step remains `continue-on-error: true` (deliberate guard so an MSIX hiccup can't block the established portable-ZIP/Inno delivery). Consequence: on a build where MSIX packaging fails, the new release globs match nothing — `softprops` skips unmatched globs by default rather than failing the release. **Glance at the "Create MSIX package" step log to confirm the `.msixupload` was produced before relying on the release asset.** - No behavior change to the portable ZIP or Inno installer paths. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

@jensenpat

Release-prep for **v26.6.2**, a consolidated release rolling up the 26.6.1 feature wave, the v26.6.1.1 hotfixes, and new work through aethersdr#3443. Bumps version 26.6.1.1 → 26.6.2 in `CMakeLists.txt` and the `README.md` banner, and prepends the v26.6.2 `CHANGELOG.md` entry. No code changes. Headline content: runtime theming system, three HID controller classes (StreamDeck+, Ulanzi Dial, Icom RC-28), the packet-radio suite (KISS-over-TCP TNC aethersdr#3279, connected-mode BBS terminal aethersdr#3381, PMS mailbox), and the Microsoft Store MSIX packaging path (aethersdr#3178/aethersdr#3205/aethersdr#3225/aethersdr#3281). 💻 Generated with Claude Code (Opus 4.8) with architecture by @jensenpat Co-authored-by: Codex <noreply@openai.com>

jensenpat requested review from a team as code owners May 29, 2026 21:23

jensenpat mentioned this pull request May 31, 2026

fix(eq): stop EQ band sliders painting inverted blue fill #3280

Merged

ten9876 merged commit e68f445 into main Jun 5, 2026
3 checks passed

ten9876 deleted the worktree-msix-auto-update branch June 5, 2026 15:34

ten9876 mentioned this pull request Jun 5, 2026

ci(windows): MSIX/Store follow-ups from PR #3281 #3406

Open

jensenpat mentioned this pull request Jun 8, 2026

release: prep v26.6.2 (CHANGELOG + README + CMakeLists) #3455

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ci(windows): attach MSIX/.msixupload to release; document Store automation plan#3281

ci(windows): attach MSIX/.msixupload to release; document Store automation plan#3281
ten9876 merged 2 commits into
mainfrom
worktree-msix-auto-update

jensenpat commented May 29, 2026

Uh oh!

ten9876 commented May 30, 2026

Uh oh!

aethersdr-agent Bot commented May 30, 2026

Uh oh!

jensenpat commented May 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jensenpat commented May 29, 2026

What

Why

Changes

Notes / risk

Uh oh!

ten9876 commented May 30, 2026

Uh oh!

aethersdr-agent Bot commented May 30, 2026

Review

One substantive suggestion: don't attach the raw .msix to the public release

Uh oh!

jensenpat commented May 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

One substantive suggestion: don't attach the raw `.msix` to the public release