Stop analog S-Meter pulsing when PGXL is in OPERATE (#2927). Principle II.#3172
Merged
Conversation
…e II. Three writers were racing into SMeterWidget::setTxMeters() whenever the PGXL was in OPERATE: 1. MainWindow.cpp:3455 — unconditional connect from MeterModel:: txMetersChanged (exciter FWDPWR, ~100 W). 2. MainWindow.cpp:3654 — amp handler, gated on ampOperate(), ~1500 W. 3. MainWindow.cpp:3541 — direct PGXL TCP peakfwd path, gated on ampOperate(). Writers 2 and 3 already respected "amp owns the meter in OPERATE"; writer 1 did not, so the analog meter alternated exciter -> amp -> exciter on whatever ticks happened to land — the user-visible pulsing. The PGXL bar graph in AmpApplet was steady because it has a single writer (ampMetersChanged). Gate the exciter connect on !ampOperate() so STANDBY still feeds the meter from the exciter and OPERATE has a single deterministic writer (the amp path). Display-side only — no protocol or model changes.
2 tasks
jensenpat
approved these changes
May 25, 2026
jensenpat
left a comment
Collaborator
There was a problem hiding this comment.
meter fix w/ amp active
2 tasks
G6PWY-Chris
pushed a commit
to G6PWY-Chris/AetherSDR
that referenced
this pull request
Jun 22, 2026
… Principle II. (aethersdr#3172) ## Summary Fixes aethersdr#2927 aethersdr#2393 ### What was changed Stop analog S-Meter pulsing when PGXL is in OPERATE (aethersdr#2927). Principle II. ### Files modified - `src/gui/MainWindow.cpp` ``` src/gui/MainWindow.cpp | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) ``` --- Generated by AetherClaude (automated agent for AetherSDR) --- <sub>🤖 aethersdr-agent · cost: $1.9570 · model: claude-opus-4-7</sub> Co-authored-by: aethersdr-agent[bot] <273844287+aethersdr-agent[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2927 #2393
What was changed
Stop analog S-Meter pulsing when PGXL is in OPERATE (#2927). Principle II.
Files modified
src/gui/MainWindow.cppGenerated by AetherClaude (automated agent for AetherSDR)
🤖 aethersdr-agent · cost: $1.9570 · model: claude-opus-4-7