rigctl: append RPRT terminator to all bare-mode getters (#3120). Principle I.#3127
Merged
Conversation
…ciple I. Hamlib's NET rigctl reference appends RPRT N to every response in both bare and extended modes. AetherSDR's bare-mode long-form getters omitted the terminator on 10 commands (chk_vfo, get_powerstat, hamlib_version, get_split_freq_mode, get_vfo_list, get_modes, get_rptr_shift, get_rptr_offs, get_ctcss_tone, get_dcs_code). Clients other than WSJT-X — fldigi, JTDX, hamlib-cli, etc. — may stall waiting for the missing terminator the same way WSJT-X stalled on get_lock_mode in #3115. Mechanical sweep: each bare branch now returns the value lines plus rprt(0), mirroring the Hamlib reference exactly. Extended-mode branches already carried the terminator and are unchanged. Short-form single-character getters are left alone — they follow a different convention that omits RPRT (see cmdGetFreq and siblings). Each new bare-mode terminator gets a regression assertion in tests/rigctld_test.cpp section 13 (13.11–13.20), following the 13.10 / #3115 pattern of asserting the exact two-line {value, "RPRT 0"} response. get_split_freq_mode is 4 lines bare (freq, mode, passband, RPRT 0) and accepts the alternate "RPRT -1" shape when no TX slice exists. Principle I (FlexLib / upstream-protocol authority): Hamlib's NET rigctl backend is the reference for this on-wire protocol; the bare-mode omission was a divergence from that reference. Restoring conformance is the load-bearing principle. Blast radius: codegraph impact on processCommand reports risk_score=0.104 with 5 high-risk downstream model accessors (RadioModel::transmitModel/sendCmd/isConnected/sendCmdPublic, SliceModel::sliceId). These are read by the cmd handlers that the unchanged branches dispatch to; the edits here are purely textual additions to return values and do not touch handler bodies or any downstream model state. The PreToolUse file-level hook flagged risk_score=0.182 with MainWindow as a transitive caller via header inclusion — same conclusion: text-only return-value change, no behavioural ripple. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
G6PWY-Chris
pushed a commit
to G6PWY-Chris/AetherSDR
that referenced
this pull request
Jun 22, 2026
…). Principle I. (aethersdr#3127) ## Summary Fixes aethersdr#3120 ### What was changed rigctl: append RPRT terminator to all bare-mode getters (aethersdr#3120). Principle I. ### Files modified - `src/core/RigctlProtocol.cpp` - `tests/rigctld_test.cpp` ``` src/core/RigctlProtocol.cpp | 20 ++++++------- tests/rigctld_test.cpp | 68 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 78 insertions(+), 10 deletions(-) ``` --- Generated by AetherClaude (automated agent for AetherSDR) --- <sub>🤖 aethersdr-agent · cost: $10.2367 · model: claude-opus-4-7</sub> Co-authored-by: aethersdr-agent[bot] <273844287+aethersdr-agent[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3120
What was changed
rigctl: append RPRT terminator to all bare-mode getters (#3120). Principle I.
Files modified
src/core/RigctlProtocol.cpptests/rigctld_test.cppGenerated by AetherClaude (automated agent for AetherSDR)
🤖 aethersdr-agent · cost: $10.2367 · model: claude-opus-4-7