refactor(containers): ContainerWidget optional dragId eliminates AppletPanel fallback (#3057). Principle IX.#3058
Merged
Merged
Conversation
…etPanel fallback (#3057). Principle IX. Adds ContainerWidget::dragId() / setDragId() so composite tiles can declare the drag MIME payload that matches their owning AppletEntry.id directly. TXDSP now sets dragId("TXDSP") at the wrap site; the aliasing fallback in AppletPanel::dropEvent (added in #3044 to fix #1836) is now dead code and removed in this PR. Behavior-preserving: - Non-composite tiles: m_dragId stays empty, dragId() returns m_id — drag MIME unchanged. - TXDSP: drag MIME is now "TXDSP" (matches AppletEntry.id) instead of "tx_dsp" (the internal container id) — fast-path lookup hits directly. - Container persistence keys (ContainerGeometry_tx_dsp, ContainerTree parent refs) read m_id, not m_dragId — completely unaffected. No migration needed. Net diff is negative: ~12 LOC added in ContainerWidget header, 1 line changed in ContainerWidget.cpp, +6 lines at the TXDSP wrap site, -14 lines of fallback removed in AppletPanel::dropEvent. Pure refactor. Blast radius: risk_score=0.275, 10 high-risk affected (top: MainWindow, AppletPanel ctor, MainWindow::buildUI). The transitive callers reach via AppletPanel construction; the actual API surface change is purely additive (new method, new field with default-empty semantics), so no caller behavior changes. The only behavior delta is the TXDSP wrap site explicitly opting into the new dragId. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
4 tasks
G6PWY-Chris
pushed a commit
to G6PWY-Chris/AetherSDR
that referenced
this pull request
Jun 22, 2026
…etPanel fallback (aethersdr#3057). Principle IX. (aethersdr#3058) ## Summary Fixes aethersdr#3057 ### What was changed refactor(containers): ContainerWidget optional dragId eliminates AppletPanel fallback (aethersdr#3057). Principle IX. ### Files modified - `src/gui/AppletPanel.cpp` - `src/gui/containers/ContainerWidget.cpp` - `src/gui/containers/ContainerWidget.h` ``` src/gui/AppletPanel.cpp | 26 ++++++++++---------------- src/gui/containers/ContainerWidget.cpp | 2 +- src/gui/containers/ContainerWidget.h | 10 ++++++++++ 3 files changed, 21 insertions(+), 17 deletions(-) ``` --- Generated by AetherClaude (automated agent for AetherSDR) --- <sub>🤖 aethersdr-agent · cost: $6.8496 · model: claude-opus-4-7</sub> Co-authored-by: aethersdr-agent[bot] <273844287+aethersdr-agent[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3057
What was changed
refactor(containers): ContainerWidget optional dragId eliminates AppletPanel fallback (#3057). Principle IX.
Files modified
src/gui/AppletPanel.cppsrc/gui/containers/ContainerWidget.cppsrc/gui/containers/ContainerWidget.hGenerated by AetherClaude (automated agent for AetherSDR)
🤖 aethersdr-agent · cost: $6.8496 · model: claude-opus-4-7