cleanup(spectrum): remove dead FFT accumulator state after #3031 (#3038). Principle IX.#3040
Merged
Conversation
…). Principle IX. PR #3031 (TX waterfall scroll-rate parity) removed the debt-gated FFT row emission and per-frame linear-power accumulator from SpectrumWidget::pushWaterfallRow but intentionally left the supporting state in place to keep the behavioural-fix diff focused. This commit removes that now-dead state: - m_lastFftRowMs, m_lastFftFrameMs, m_fftRowDebtMs (pacing timestamps for the removed debt gate) - m_fftAccumPower, m_fftAccumCount (per-bin linear-power accumulator for the removed inter-frame averaging) - SpectrumWidget::resetFftWaterfallAccumulator() and its 4 call sites in setWfLineDuration(), setTransmitting(true), setTxWaterfallSlice(), and clearTxWaterfallSlice() — each was a bare statement with no surrounding logic to untangle Grep across the codebase confirmed the only writes to these members were inside the reset function itself, and no read sites remained anywhere. Pure dead-code removal — 26 LOC net, zero behavioural change. The TX waterfall scroll-rate parity verified by #3031 covers the path. Blast radius: removed symbols are private to SpectrumWidget; the PreToolUse hook flagged risk_score=0.291 against SpectrumWidget.h/.cpp as whole TUs (high-bw MainWindow callers exist) but those callers do not touch the removed private members — confirmed by grep before edit.
Contributor
Author
There was a problem hiding this comment.
LGTM — this is exactly the follow-up #3031 called out. Verified locally that no other call sites reference resetFftWaterfallAccumulator, m_fftAccumPower, m_fftAccumCount, m_lastFftRowMs, m_lastFftFrameMs, or m_fftRowDebtMs after these deletions, so the removal is clean and tightly scoped to the two files. No conventions or boundary concerns here (pure dead-state removal — no AppSettings, RAII, or error-handling surface touched). Thanks for the cleanup!
🤖 aethersdr-agent · cost: $4.4449 · model: claude-opus-4-7
G6PWY-Chris
pushed a commit
to G6PWY-Chris/AetherSDR
that referenced
this pull request
Jun 22, 2026
…3031 (aethersdr#3038). Principle IX. (aethersdr#3040) ## Summary Fixes aethersdr#3038 ### What was changed cleanup(spectrum): remove dead FFT accumulator state after aethersdr#3031 (aethersdr#3038). Principle IX. ### Files modified - `src/gui/SpectrumWidget.cpp` - `src/gui/SpectrumWidget.h` ``` src/gui/SpectrumWidget.cpp | 14 -------------- src/gui/SpectrumWidget.h | 12 ------------ 2 files changed, 26 deletions(-) ``` --- Generated by AetherClaude (automated agent for AetherSDR) --- <sub>🤖 aethersdr-agent · cost: $10.0359 · model: claude-opus-4-7</sub> Co-authored-by: aethersdr-agent[bot] <273844287+aethersdr-agent[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3038
What was changed
cleanup(spectrum): remove dead FFT accumulator state after #3031 (#3038). Principle IX.
Files modified
src/gui/SpectrumWidget.cppsrc/gui/SpectrumWidget.hGenerated by AetherClaude (automated agent for AetherSDR)
🤖 aethersdr-agent · cost: $10.0359 · model: claude-opus-4-7