refactor(gui): collapse redundant revealOffscreen comfortMargin ternary (#3033). Principle XI.#3039
Merged
Merged
Conversation
…ry (#3033). Principle XI. Post-#3030, the RevealOffscreen branch returns the same comfort margin as the default arm, so the 3-way ternary at MainWindow.cpp:12241-12244 was misleading about implying two distinct behaviors. Collapse to a 2-way ternary on isSpectrumClick alone, and drop the now-unused `revealOffscreen` local (would trip -Wunused-variable on strict-warnings configs). Pulled the explanatory comment forward and reframed it now that the explicit RevealOffscreen branch is gone. Pure refactor: both removed branches resolved to the same constant (kRevealComfortEdgeMarginFrac = 0.18), so no behavior change. The revealOffscreen parameter at MainWindow.cpp:10656 is a separate, unrelated function-parameter scope and is untouched. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
G6PWY-Chris
pushed a commit
to G6PWY-Chris/AetherSDR
that referenced
this pull request
Jun 22, 2026
…ry (aethersdr#3033). Principle XI. (aethersdr#3039) ## Summary Fixes aethersdr#3033 ### What was changed refactor(gui): collapse redundant revealOffscreen comfortMargin ternary (aethersdr#3033). Principle XI. ### Files modified - `src/gui/MainWindow.cpp` ``` src/gui/MainWindow.cpp | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) ``` --- Generated by AetherClaude (automated agent for AetherSDR) --- <sub>🤖 aethersdr-agent · cost: $2.2634 · model: claude-opus-4-7</sub> Co-authored-by: aethersdr-agent[bot] <273844287+aethersdr-agent[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3033
What was changed
refactor(gui): collapse redundant revealOffscreen comfortMargin ternary (#3033). Principle XI.
Files modified
src/gui/MainWindow.cppGenerated by AetherClaude (automated agent for AetherSDR)
🤖 aethersdr-agent · cost: $2.2634 · model: claude-opus-4-7