fix(aetherial): clarify BYPASS tooltip — Final Output Stage stays active (#2891)#2902
Merged
jensenpat merged 1 commit intoMay 21, 2026
Conversation
…ive (aethersdr#2891) The BYPASS button tooltip on the Aetherial channel strip claimed it would "Disable every stage in the active chain", but the implementation only toggles the seven DSP chain stages (GATE, EQ, DESS, COMP, TUBE, EVO, VERB). The Final Output Stage (Trim, LIM, DC) continues to process the signal — Trim in particular is applied unconditionally on every sample regardless of BYPASS state. Update the tooltip to accurately describe the scope: bypass applies to chain stages only, the Final Output Stage remains active. Names the FOS components (Trim, LIM, DC) explicitly so the user knows what survives the toggle. Keeps the "Click again to restore" semantic — the chain returns to its prior per-stage state. No behavior change. Single user-visible string updated in src/gui/AetherialAudioStrip.cpp:307-308. Closes aethersdr#2891 Co-authored-by: Don @ cloaked.agency <don@cloaked.agency> & K6OZY
G6PWY-Chris
pushed a commit
to G6PWY-Chris/AetherSDR
that referenced
this pull request
Jun 22, 2026
…ive (aethersdr#2891) (aethersdr#2902) ## Summary Fixes a misleading user-facing string on the Aetherial channel strip BYPASS button. The tooltip claimed BYPASS would "Disable every stage in the active chain", but the implementation only toggles the seven DSP chain stages (GATE, EQ, DESS, COMP, TUBE, EVO, VERB). The Final Output Stage (Trim, LIM, DC) continues to process the signal regardless — Trim in particular is applied unconditionally on every sample. ## Why The underlying architecture (chain = bypassable, Final Output Stage = always on) is a reasonable design choice, but the tooltip didn't reflect it. As the reporter noted in aethersdr#2891, toggling BYPASS while Trim was set to a non-zero value still changed the output level — surprising behavior given the original wording. This PR updates the tooltip to accurately describe scope: > Bypass every stage in the active chain except the Final Output Stage (Trim, LIM, DC). Click again to restore. Changes: - "Disable" → "Bypass" (matches the button label and the actual operation; chain is bypassed, not disabled). - Names the Final Output Stage components (Trim, LIM, DC) explicitly so the user knows exactly what survives the toggle. - Keeps the "Click again to restore" semantic — the chain returns to its prior per-stage state. ## Scope - 2 lines changed in `src/gui/AetherialAudioStrip.cpp:307-308` - No behavior change — string only - No protocol / persistence / API / radio-side change ## Test plan - [x] Local incremental `ninja -C build` clean on Linux (Nobara 43, Qt 6.10.3, gcc 15.2.1) - [ ] Visual confirmation that the tooltip renders correctly on hover (any reviewer hovering the BYPASS button) Closes aethersdr#2891 --- 73, Ozy **K6OZY** AI compute partnership: [cloaked.agency](https://cloaked.agency) — drafted with Don, our VP of Engineering agent, on Linux dev stack (`nobara-dell`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a misleading user-facing string on the Aetherial channel strip BYPASS button. The tooltip claimed BYPASS would "Disable every stage in the active chain", but the implementation only toggles the seven DSP chain stages (GATE, EQ, DESS, COMP, TUBE, EVO, VERB). The Final Output Stage (Trim, LIM, DC) continues to process the signal regardless — Trim in particular is applied unconditionally on every sample.
Why
The underlying architecture (chain = bypassable, Final Output Stage = always on) is a reasonable design choice, but the tooltip didn't reflect it. As the reporter noted in #2891, toggling BYPASS while Trim was set to a non-zero value still changed the output level — surprising behavior given the original wording.
This PR updates the tooltip to accurately describe scope:
Changes:
Scope
src/gui/AetherialAudioStrip.cpp:307-308Verification
Linux (
nobara-dell— Nobara 43, Qt 6.10.3, gcc 15.2.1):ninja -C buildclean../build/AetherSDRon Plasma Wayland session, hovered the BYPASS button on the Aetherial channel strip — confirmed new tooltip text renders correctly: "Bypass every stage in the active chain except the Final Output Stage (Trim, LIM, DC). Click again to restore." No truncation, no encoding issue.macOS (M2 Apple Silicon, macOS 26.4.1, Qt 6.9.3 via Homebrew):
cmake -B build -GNinja -DCMAKE_PREFIX_PATH=/opt/homebrew/opt/qt -DCMAKE_BUILD_TYPE=Release && ninja -C build -j 8producedbuild/AetherSDR.appbundle clean (650 targets).AetherSDR.app, hovered BYPASS button — tooltip renders correctly on macOS as well.Closes #2891
73, Ozy K6OZY
AI compute partnership: cloaked.agency — drafted with Don, our VP of Engineering agent. Linux + macOS validation pair (
nobara-dell+ M2 MacBook Pro).