fix(libmodem_core): qualify member access with this-> for gcc 11 two-phase lookup#2799
Merged
ten9876 merged 1 commit intoMay 17, 2026
Merged
Conversation
…phase lookup The AppImage CI build (ubuntu-22.04 native runner, stock gcc 11.4) failed on third_party/libmodem_core/bitstream.h:192 with: error: 'container' was not declared in this scope; did you mean 'Container'? inside the noexcept(noexcept(...)) clause of traits_back_insert_iterator::operator=. Stricter compilers require explicit this->container qualification for template class member access in the function signature; the existing unqualified form passed on newer gcc (our Docker CI image) but not gcc 11. Adds this-> on both call sites (the noexcept clause and the function body, for consistency). Pure portability fix — zero user-visible change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Merged
ten9876
added a commit
that referenced
this pull request
May 17, 2026
Hotfix recommended for TCI digital-mode operators, Windows users with MQTT or floating-panel windows, and Linux Ubuntu 22.04 builders. - TCI TX audio level regression vs v26.5.1 (#2806/#2807) — restores WSJT-X / JTDX output to full level by reverting only the device + protocol identity strings from #2597 to a form that bypasses WSJT-X's TCITransceiver SunSDR2DX/non-ExpertSDR3 gain trap. - Windows process lingering in Task Manager after close (#2802, chibondking) — three independent root causes addressed: Channel Strip + applet-panel float window WA_QuitOnClose, MqttClient destructor loop_stop. - AppImage CI build failure on gcc 11 strict mode (#2799) — qualifies bitstream.h:192 member access with `this->` for two-phase name lookup. Restores the v26.5.2 x86_64 AppImage artifact. - SSA (Sweden) band plan (#2805, NF0T) — Swedish national overlay with PTSFS 2025:1 constraints, Swedish labels, 89 spots. Bumps version 26.5.2 → 26.5.2.1 in CMakeLists.txt, README.md, CLAUDE.md; regenerates WhatsNewData.cpp from CHANGELOG.md. CalVer scheme expanded to YY.M.patch[.hotfix] to document the 4th-component hotfix convention used historically. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AppImage CI build (ubuntu-22.04 native runner, stock gcc 11.4)
failed on third_party/libmodem_core/bitstream.h:192 with:
error: 'container' was not declared in this scope; did you mean 'Container'?
inside the noexcept(noexcept(...)) clause of traits_back_insert_iterator::operator=.
Stricter compilers require explicit this->container qualification for
template class member access in the function signature; the existing
unqualified form passed on newer gcc (our Docker CI image) but not gcc 11.
Adds this-> on both call sites (the noexcept clause and the function
body, for consistency). Pure portability fix — zero user-visible change.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com