Pull request overview

Extends the “startup/reconnect panadapter layout restore” grace window so the saved PanadapterLayout can still be applied even if panadapter status arrives slowly, and prevents the automatic restore from overriding an explicit user-selected layout.

Changes:

• Increase kPanLayoutRestoreWindowMs from 5s to 30s.
• When the user explicitly selects a panadapter layout during startup, stop the pending startup restore timer and clear the restore window to prevent later automatic overrides.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Thanks for the fix @rfoust — extending the window to 30 s addresses the slow-radio startup case cleanly, and the diff is appropriately scoped.

One concern, which mirrors Copilot's finding and I think is real:

Cancelling the timer also cancels restoreFloatingState()

The timer callback at src/gui/MainWindow.cpp:2603-2661 does two things:

1. If panCount > 1, call m_panStack->rearrangeLayout(...) (the part you want to suppress).
2. Unconditionally call m_panStack->restoreFloatingState() at line 2660 (the part you probably still want).

When the user picks a layout from m_addPanLabel at line 5949, the new m_layoutRestoreTimer->stop() cancels the whole callback, so any saved floating-pan windows that hadn't yet been restored stay docked. With the window now 30 s wide, the chance of a user clicking before floating restore has run is meaningfully higher than under the old 5 s window.

Suggested fix — restore floating state directly at the cancel site, then suppress only the layout-rearrange portion:

if (m_layoutRestoreTimer) {
    m_layoutRestoreTimer->stop();
}
m_layoutRestoreUntilMs = 0;
if (m_panStack) {
    m_panStack->restoreFloatingState();
}

Or pull floating-state restore out of the timer callback entirely and trigger it independently once any pan exists.

Everything else looks good — m_layoutRestoreTimer is null-checked before stop(), and setting m_layoutRestoreUntilMs = 0 correctly prevents the restart path at line 2667 from re-arming the timer on subsequent pan messages.