fix(streamdeck): bump tune-up/down step from 100 Hz to 1 kHz (#2409)#2714
Conversation
The Elgato Stream Deck plugin's tune-up/tune-down actions stepped the VFO by 100 Hz per press, which is impractical on HF — 5 kHz takes 50 button presses. Hoist the step to a named TUNE_STEP_HZ constant and set it to 1000 Hz, matching the sibling streamcontroller-aethersdr plugin (which already uses 1 kHz). Bumps manifest Version to 1.0.1.0 and rebuilds the .streamDeckPlugin bundle. TCI command form (vfo:0,0,<hz>;) is unchanged — only the delta differs. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
There was a problem hiding this comment.
Thanks for the streamdeck fix — the plugin.js change itself is clean: extracting TUNE_STEP_HZ = 1000 and bumping the manifest version is exactly right for the 100 Hz → 1 kHz step.
However, this PR also deletes 45 lines from src/gui/MainWindow.cpp that are completely outside the stated scope, and they reverse PR #2710 (Add RF Gain and AGC-T shortcuts) — which is literally the commit immediately preceding this PR's base.
Specifically deleted:
stepActivePanRfGainlambda (helper for stepping the active panadapter's RF gain)rf_gain_up/rf_gain_downshortcut registrationsagct_up/agct_downshortcut registrations
git show a3ff72e1 confirms those exact lines were just added by jensenpat in #2710 (merged ~7 hours before this PR was opened). Nothing in this PR's stated scope (a streamdeck-plugin tuning step) touches MainWindow.cpp, the description doesn't mention removing shortcuts, and there's no rationale for the revert.
This looks like the branch was cut from a stale main and these deletions snuck in via a bad rebase/merge. Please drop the src/gui/MainWindow.cpp hunk entirely before merge — otherwise this silently regresses #2710.
Once MainWindow.cpp is dropped, the rest of the PR (manifest.json + plugin.js + rebuilt .streamDeckPlugin binary) looks good for #2409.
The original streamdeck-tune-step commit (3233762) was authored on top of a pre-#2710 main and inadvertently removed the 45 lines that PR #2710 added to MainWindow.cpp (stepActivePanRfGain lambda + four registerAction calls for rf_gain_up / rf_gain_down / agct_up / agct_down). Restore MainWindow.cpp to match origin/main so the Stream Deck plugin change can land without silently reverting the RF Gain / AGC-T shortcut feature. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The CWX F1-F12 commit (781358a) was generated against a SpectrumWidget snapshot from before PR #2717 landed and inadvertently reverted those ~107 lines: removed the m_draggingDbmRange / m_dbmDragStartRange / m_dbmDragStartBottom members and undid the matching press/move/release handling, the isDraggingDbmScale() update, the noise-floor guard swap, and the paint-order fix. Restore src/gui/SpectrumWidget.{cpp,h} to the current main state so the CWX F1-F12 additions in MainWindow.cpp and RadioSetupDialog.cpp can land without reverting #2717. Same pattern as the restoration commit on PR #2714 earlier today — worth investigating the agent's snapshot/cache behaviour upstream. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary
Fixes #2409
What was changed
fix(streamdeck): bump tune-up/down step from 100 Hz to 1 kHz (#2409)
Files modified
plugins/elgato-aethersdr/com.aethersdr.radio.sdPlugin/manifest.jsonplugins/elgato-aethersdr/com.aethersdr.radio.sdPlugin/plugin.jsplugins/elgato-aethersdr/com.aethersdr.radio.streamDeckPluginGenerated by AetherClaude (automated agent for AetherSDR)