Hide 8000-series DSP filters (NRL, NRS, RNN, NRF) on 6000-series radios (#2177)#2184
Merged
Conversation
6000-series radios (FLEX-6300/6400/6500/6600/6700) don't expose the extended firmware DSP filters that 8000-class hardware does (NRL, NRS, RNN, NRF). Showing them in the UI when connected to a 6000-series is confusing and clutters the DSP panel. Adds RadioModel::hasExtendedDspFilters() — returns true for BigBend (8400, 8600), DragonFire (AU-, ML-, CL-, RT-) platforms. Both the VfoWidget DSP buttons and the SpectrumOverlayMenu DSP rows hide those four filters when this returns false. Carved out of PR #2178 (bot, no maintainerCanModify) which had a diff that included unrelated -390 lines reverting PR #2155 (Customizable Slice Colors) — its branch was based on the moment #2155 landed but it didn't include the SliceColorManager source files, so a rebase showed them as deletions. This carve-out is just the substantive +47/-4 hide-filter change. Improvement over the original PR: the bot only gated the 4 buttons in setSlice()'s mode-change lambda. This commit also gates them in the syncFromSlice() path (line 2915 region) so subsequent mode changes re-apply the gating consistently. Fixes #2177. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Apr 30, 2026
ten9876
added a commit
that referenced
this pull request
May 1, 2026
NRL was incorrectly grouped with the 8000-series-only firmware DSP filters in #2184, but it's actually available on 6000-series radios too — only NRS, RNN, and NRF are 8000/AU-platform-only. Drop NRL from the hide-list in both `SpectrumOverlayMenu::setHasExtendedDsp` and the two `VfoWidget` visibility paths (setSlice mode-change lambda + syncFromSlice). NRL now follows the same pattern as NB/NR/NR2 — visible unless the mode hides it (FM). Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hides the four extended firmware DSP filters (NRL, NRS, RNN, NRF) when connected to a 6000-series radio, since those filters only exist on BigBend/DragonFire-platform hardware (8400, 8600, AU-/ML-/CL-/RT-series).
Provenance
Carve-out of PR #2178 (authored by AetherClaude bot, `maintainerCanModify: false`). The bot's branch was based on the moment PR #2155 (Customizable Slice Colors) landed but didn't include the new SliceColorManager source files, so rebasing showed those as −390 deletions — i.e., merging #2178 as-submitted would silently revert chibondking's slice-colors work that landed earlier today.
This branch contains just the substantive +47/-4 hide-filter change, applied cleanly on top of current main.
Implementation
Improvement over the original PR
The bot only added the gating to the `setSlice` mode-change lambda. This commit also adds it to `syncFromSlice` (line 2915 region) — a sibling code path — so subsequent mode changes re-apply the gating consistently. Without that, switching from FM → USB → FM on a 6000-series would re-show the four buttons.
Test plan
🤖 Generated with Claude Code