Skip to content

Fix spectrum/waterfall frequency misalignment and timing lag (#1690)#1694

Closed
aethersdr-agent[bot] wants to merge 1 commit into
mainfrom
aetherclaude/issue-1690
Closed

Fix spectrum/waterfall frequency misalignment and timing lag (#1690)#1694
aethersdr-agent[bot] wants to merge 1 commit into
mainfrom
aetherclaude/issue-1690

Conversation

@aethersdr-agent

Copy link
Copy Markdown
Contributor

Summary

Fixes #1690

What was changed

Fix spectrum/waterfall frequency misalignment and timing lag (#1690)

Files modified

  • src/gui/SpectrumWidget.cpp
  • src/gui/SpectrumWidget.h
 src/gui/SpectrumWidget.cpp | 6 +++---
 src/gui/SpectrumWidget.h   | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

Generated by AetherClaude (automated agent for AetherSDR)

- Fix QPainter bin-to-pixel mapping from i/n to i/(n-1) for edge-to-edge
  alignment, matching the GPU path and eliminating ~100 Hz offset
- Increase SMOOTH_ALPHA from 0.35 to 0.50 so spectrum trace responds
  faster to transients (reduces CW lag vs waterfall)
- Use center-of-bin mapping in fallback waterfall for consistency

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ten9876 pushed a commit that referenced this pull request Apr 21, 2026
AetherClaude contribution — applies the two legit alignment fixes from
#1694 and skips the SMOOTH_ALPHA tuning change which is a UX decision.

- Waterfall bin index uses pixel-center sampling
  ((x + 0.5) * bins / destWidth) so the same frequency lands on the
  same x coordinate in spectrum and waterfall.  Previously a half-bin
  offset drifted the two panes.
- Spectrum x-coord uses \`i / (n - 1)\` so the last sample lands exactly
  at the right edge instead of one pixel short.
- Empty-data guard loosened from \`isEmpty()\` to \`size() < 2\` so
  single-point transient states don't try to draw a line segment.

Scope deliberately narrowed: the original PR also bumped
SMOOTH_ALPHA 0.35 → 0.50 as a perceived-lag improvement; that's a
user-facing rendering tuning change that needs maintainer sign-off
and is better reviewed independently from the alignment bug fix.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@ten9876

ten9876 commented Apr 21, 2026

Copy link
Copy Markdown
Collaborator

Landed on main as 700326fapplied the alignment bug fixes only (pixel-center waterfall bin index, i/(n-1) spectrum x-coord, size<2 guard).

Skipped the SMOOTH_ALPHA 0.35 → 0.50 tuning change since that's a user-facing rendering responsiveness decision that deserves its own review — not a bug. Happy to revisit if there's a specific scenario where the current 0.35 feels wrong.

@ten9876 ten9876 closed this Apr 21, 2026
ten9876 added a commit that referenced this pull request Apr 21, 2026
)

Cuts a community-contribution-heavy point release.  Ten community PRs
landed plus an AetherClaude bug-fix batch covering TCI duplicate-stream
/ no-RF, PC Audio button sync, zoom full-BW, VFO edge jitter, audio pan
with NR, per-slice AF mute persistence, waterfall passband shading,
filter-edge jitter, NR2 crackling, rigctld Windows IPv4, DX cluster
reconnect, serial port persistence, compression meter gain reduction,
macOS audio device override, and bandwidth-correction echo guard.

Highlights for the release notes:
- macOS MNR (MMSE-Wiener spectral NR) with Accelerate/AMX acceleration
- Quick memory browse / save actions on slice overlays (jensenpat)
- Improved TNF notch interaction with bidirectional drag (rfoust)
- RAC Canada band plan expanded to VHF/UHF + 60 m ISED update (VE3NEM)
- Low-Latency DAX toggle consolidated into RADE mode
- View → Frameless Window toggle (Ctrl+Shift+F)

The #1694 spectrum/waterfall alignment attempt was landed partially
then reverted when it made alignment worse instead of better — net
zero, noted in the CHANGELOG "Reverted" section.  Issue #1690 closed
as not-a-bug.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@ten9876 ten9876 deleted the aetherclaude/issue-1690 branch April 25, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v817 spectrum and waterfal not in iso nor in sync

2 participants