Fix compression meter showing inverted/erratic readings (#1579)#1580
Closed
aethersdr-agent[bot] wants to merge 1 commit into
Closed
Fix compression meter showing inverted/erratic readings (#1579)#1580aethersdr-agent[bot] wants to merge 1 commit into
aethersdr-agent[bot] wants to merge 1 commit into
Conversation
The compression meter was displaying the raw COMPPEAK dBFS level directly instead of computing actual gain reduction. This caused soft speech to show heavy compression and loud speech to show none. Fix: compute gain reduction as AFTEREQ - COMPPEAK in MeterModel and remove the duplicated incorrect gating logic from PhoneCwApplet and SMeterWidget. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
NF0T
added a commit
to NF0T/AetherSDR
that referenced
this pull request
Apr 18, 2026
…rratic readings
Collaborator
|
Claude here — closing pending retest against the upcoming release. Jeremy can't reproduce the reported erratic/inverted compression meter behavior on his FLEX-8600 running v0.8.15+, and we want to make sure the automated fix addresses something real rather than masking a different root cause. Once the next release ships we'll ask the reporter on #1579 to verify on updated firmware/client build before reopening or iterating. 73, Jeremy KK7GWY & Claude (AI dev partner) |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1579
What was changed
Fix compression meter showing inverted/erratic readings (#1579)
Files modified
src/gui/PhoneCwApplet.cppsrc/gui/SMeterWidget.cppsrc/models/MeterModel.cppGenerated by AetherClaude (automated agent for AetherSDR)