Fix FlexControl tuning jitter caused by optimistic/confirmed frequency race (#1524)#1527
Merged
Conversation
…y race (#1524) Two fixes to eliminate VFO line flicker during rapid FlexControl tuning: 1. Guard the flex target reset so it doesn't snap back to the stale radio-confirmed frequency while the coalesce timer is still active. 2. Skip overlay frequency updates from radio confirmations while encoder tuning is in progress — the optimistic VFO position is already ahead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
NF0T
added a commit
to NF0T/AetherSDR
that referenced
this pull request
Apr 17, 2026
…nfirmed frequency race)
NF0T
added a commit
to NF0T/AetherSDR
that referenced
this pull request
Apr 17, 2026
…oalesce timer check m_flexCoalesceTimer and m_hidCoalesceTimer are conditionally declared under HAVE_SERIALPORT and HAVE_HIDAPI respectively. The merged code referenced both unconditionally, causing a compile error on any build without HIDAPI installed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
|
While integrating this PR into a local staging branch for testing, we hit a compile error on any build where HIDAPI is not installed: Both members are declared under conditional guards in #ifdef HAVE_SERIALPORT
QTimer m_flexCoalesceTimer;
#endif
#ifdef HAVE_HIDAPI
QTimer m_hidCoalesceTimer;
#endifBut the new usage at the merge site references both unconditionally: bool activeTuning = m_flexCoalesceTimer.isActive() || m_hidCoalesceTimer.isActive();This will fail to compile on any platform where HIDAPI is absent (e.g. a Windows build without bool activeTuning = false;
#ifdef HAVE_SERIALPORT
activeTuning = activeTuning || m_flexCoalesceTimer.isActive();
#endif
#ifdef HAVE_HIDAPI
activeTuning = activeTuning || m_hidCoalesceTimer.isActive();
#endifWe've applied this locally in our staging branch. Flagging for the PR author to patch before merge. |
NF0T
added a commit
to NF0T/AetherSDR
that referenced
this pull request
Apr 18, 2026
…oalesce timer check m_flexCoalesceTimer and m_hidCoalesceTimer are conditionally declared under HAVE_SERIALPORT and HAVE_HIDAPI respectively. The merged code referenced both unconditionally, causing a compile error on any build without HIDAPI installed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1524
What was changed
Fix FlexControl tuning jitter caused by optimistic/confirmed frequency race (#1524)
Files modified
src/gui/MainWindow.cppGenerated by AetherClaude (automated agent for AetherSDR)