Fix CW auto-tune Once/Loop buttons never shown for SSDR+ users#1373
Merged
Conversation
The SmartSDR+ flag was set after wireVfoWidget() called setSlice(), which triggers rebuildFilterButtons(). Since m_hasSmartSdrPlus was still false at that point, only Zero Beat was ever rendered. Three changes: - Move setSmartSdrPlus() call before wireVfoWidget() so the flag is set before the first rebuildFilterButtons() runs - Make setSmartSdrPlus() trigger rebuildFilterButtons() when the value changes and a slice is attached, handling late updates - Connect RadioModel::infoChanged to propagate subscription changes to all existing VFO widgets when license info arrives after creation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
problem returned in 0.8.12.1 |
chibondking
pushed a commit
to chibondking/AetherSDR
that referenced
this pull request
Apr 14, 2026
…rsdr#1356) (aethersdr#1373) The SmartSDR+ flag was set after wireVfoWidget() called setSlice(), which triggers rebuildFilterButtons(). Since m_hasSmartSdrPlus was still false at that point, only Zero Beat was ever rendered. Three changes: - Move setSmartSdrPlus() call before wireVfoWidget() so the flag is set before the first rebuildFilterButtons() runs - Make setSmartSdrPlus() trigger rebuildFilterButtons() when the value changes and a slice is attached, handling late updates - Connect RadioModel::infoChanged to propagate subscription changes to all existing VFO widgets when license info arrives after creation Co-authored-by: AetherClaude <aetherclaude@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1356. From AetherClaude PR #1358.
🤖 Generated with Claude Code