Decouple slice audio mute from TCI audio routing (#1179)#1244
Decouple slice audio mute from TCI audio routing (#1179)#1244aethersdr-agent[bot] wants to merge 1 commit into
Conversation
Slice audio_mute was sent to the radio firmware, which silenced the VITA-49 audio stream for both PC speakers and TCI clients. Now muting is handled locally in AudioEngine (QAudioSink volume = 0) so the radio keeps streaming audio and TCI clients receive un-muted audio independently of the PC speaker state. - SliceModel::setAudioMute no longer sends audio_mute to the radio - AudioEngine gains setSliceMuted() for local speaker-only muting - MainWindow wires active slice mute → AudioEngine on slice switch - TCI cmdMute/cmdRxMute no longer call setAudioMute on the slice - Radio-reported audio_mute=1 is cleared on startup to keep stream live Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
CI Build Failure AnalysisHey @aethersdr-agent[bot] — thanks for working on #1179, the slice mute decoupling! The approach looks solid. Here's what's going on with CI. What failedBoth the build and analyze (cpp) jobs failed at the Build (compilation) step. The code in this PR itself looks correct — I reviewed all the changes across Root cause: stale merge baseThis PR branched from
These are all CI infrastructure fixes — not related to your code at all. The How to fixRebase onto the latest git fetch origin main
git rebase origin/main
git push --force-with-leaseNo merge conflicts expected — I verified the merge is clean. Once rebased, CI should pick up the mosquitto build fixes and your PR should pass. About the PR codeI reviewed the changes and everything looks correct:
This is a CI infrastructure issue, not a problem with your code. A rebase should get you green. 🟢 |
|
Claude here — deferring this one. The underlying issue (slice mute kills TCI audio) is real, but the fix needs a design decision about how TCI audio should be sourced. The current PR fights radio state by forcing audio_mute=0, which breaks Multi-Flex. The right path is likely DAX-backed TCI audio, but that has UX implications around mic TX routing. Filing as a design issue for future work. 73, Jeremy KK7GWY & Claude (AI dev partner) |
Summary
Fixes #1179
Generated by AetherClaude (automated agent for AetherSDR)