Skip to content

Exclude failed dacapo tests #6338

Merged
llxia merged 2 commits into
adoptium:masterfrom
MattyWeee123:issue6331
Jun 17, 2025
Merged

Exclude failed dacapo tests #6338
llxia merged 2 commits into
adoptium:masterfrom
MattyWeee123:issue6331

Conversation

@MattyWeee123

@MattyWeee123 MattyWeee123 commented Jun 14, 2025

Copy link
Copy Markdown
Contributor

Exclude decapo tests that failed. Using 23.11 minimal (Disabled pmd, fop, jython, h2, eclipse, luindex)

Fixes: #6331

@MattyWeee123 MattyWeee123 marked this pull request as ready for review June 14, 2025 14:08

@karianna karianna left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace needs fixing.

@MattyWeee123

Copy link
Copy Markdown
Contributor Author

Leading whitespace fixed

Comment thread perf/dacapo/playlist.xml Outdated
@karianna karianna requested review from llxia and smlambert June 15, 2025 22:20
Comment thread perf/dacapo/playlist.xml
<disable>
<comment>https://github.com/adoptium/aqa-tests/issues/4858#issuecomment-2968494739</comment>
</disable>
</disables>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of excluding all cases, we need to exclude per JDK version and platform. For dacapo-luindex, please exclude for JDK8 only (i.e., <version>8</version>).

Please update the rest of the exclusions. Thanks

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated exclusions

@llxia

llxia commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

This PR can only be fully tested if adoptium/TKG#710 (comment) is resolved.

@llxia

llxia commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

I feel this PR as well as #6341 and #6337 are mixed up.

Since we are very close to getting #6337 done, we can skip #6341. I will leave it up to you.

Reset to current upstream and only added the
playlist.xml changes.

Fixes: adoptium#6331

Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
@MattyWeee123

MattyWeee123 commented Jun 17, 2025

Copy link
Copy Markdown
Contributor Author

Let's skip #6341, sorry for the confusion. I have created a PR for adoptium/TKG#710 and cleaned up #6337.

@llxia

llxia commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

Please use the git keyword to relate to the issue. See https://github.com/adoptium/aqa-tests/blob/master/Contributing.md#submitting-a-contribution-to-aqavit for details. Thanks

@llxia llxia requested a review from LongyuZhang June 17, 2025 17:49
@MattyWeee123

MattyWeee123 commented Jun 17, 2025

Copy link
Copy Markdown
Contributor Author

Please use the git keyword to relate to the issue. See https://github.com/adoptium/aqa-tests/blob/master/Contributing.md#submitting-a-contribution-to-aqavit for details. Thanks

I believe my most recent commit has Fixes:#6331 within the description, is this incorrect?

@llxia

llxia commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

Yes, it is correct. Please also add it to the PR description. Thanks

@MattyWeee123 MattyWeee123 changed the title Exclude failed dacapo tests Exclude failed dacapo tests Fixes: #6331 Jun 17, 2025
@MattyWeee123 MattyWeee123 changed the title Exclude failed dacapo tests Fixes: #6331 Exclude failed dacapo tests Jun 17, 2025
Comment thread perf/dacapo/playlist.xml Outdated

@LongyuZhang LongyuZhang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit 20c189d into adoptium:master Jun 17, 2025
3 checks passed
@MattyWeee123 MattyWeee123 deleted the issue6331 branch June 22, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exclude failed dacapo tests

4 participants