Trial the latest Dacapo v23.11-chopin#6341
Closed
MattyWeee123 wants to merge 32 commits into
Closed
Conversation
Using https://download.dacapobench.org/chopin/dacapo-23.11-MR2-chopin.zip instead of https://sourceforge.net/projects/dacapobench/files/latest/download. Fixes: adoptium#6306 Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
Replacing the original sourceforge download with a zip cannot be directly passed as decapo.jar. Its contents should be extracted and the correct jar file inside should be decapo.jar. Fixes: adoptium#6306 Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
Observed that only one main jar file is in the upper most directory and the remaining jar files are probably dependecies. Changed build.xml to fit logic. Fixes: adoptium#6306 Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
Observed directory structure after downloading the decapo zip locally, and stoopped trying to pattern match. Hard coded movement of the main decapo jar file. Fixes: adoptium#6306 Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
ran out of space during extraction. Extract only the relevant decapo.jar file from the zip and removed redundant temporary directory. Fixes: adoptium#6306 Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
ran out of space during extraction. Extract only the relevant decapo.jar file from the zip and removed redundant temporary directory. Fixes: adoptium#6306 Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
Encountering issue where grinder can't find any tests, wondering if this is because of other dependencies in the zip. Fixes: adoptium#6306 Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
Unzips file directly to source and renames to decapo.jar and dacapo. File structure is as expected. Fixes: adoptium#6306 Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
Swapped to dacapo-minimal that has size more suitable for functional testing. Rearranged file name variables for easy changes. Fixes: adoptium#6306 Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
Parametrized decapo version in download link since its already in DACAPO_DIR_NAME. Fixes: adoptium#6306 Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
Want to double check behavior of ${TEST_ROOT} in
dacapo/build.xml.
Fixes: adoptium#6326
Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
Checking if zip is being properly retrived via the LIB declaration, file import, and the targets compile and get_zip. Fixes: adoptium#6326 Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
Seeing if code moves maven tar file into src as expected, since production TKG does not have updated dacapo dependency. Fixes: adoptium#6326 Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
Maven works as expected, should be simple transition to dacapo once TKG PR is merged. Fixed race condition with debug echo not being in an ordered target. Fixes: adoptium#6326 Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
Parametrized the dependency filename, swapped LIB value from maven to dacapo. Fixes: adoptium#6326 Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
Currently downloading empty file probably due to the link being needing a redirect to sourceforge. Sanity check in aqa-test first, then maybe make a PR to change getDependentLibs in getDependencies.xml. Fixes: adoptium#6326 Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
The dacaopo depency in getDependencies.pl currently uses an indirect link, so I executed the shell command directly with curl option -L instead of using the one imported from getDependencies.xml. Fixes: adoptium#6326 Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
karianna
approved these changes
Jun 15, 2025
llxia
reviewed
Jun 17, 2025
|
|
||
| <target name="getDependentLibs"> | ||
| <exec executable="perl" failonerror="true"> | ||
| <arg line="${TEST_ROOT}/TKG/scripts/getDependencies.pl -path ${LIB_DIR} -task default -dependencyList ${LIB} -curlOpts -L"/> |
Contributor
There was a problem hiding this comment.
We should not use getDependencies.pl. Please just update the original code <var name="curl_options" value="-Lks -C - https://sourceforge.net/projects/dacapobench/files/latest/download -o dacapo.jar"/> to download the dacapo-23.11-MR2-chopin-minimal jar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #4858