Skip to content

Trial the latest Dacapo v23.11-chopin#6341

Closed
MattyWeee123 wants to merge 32 commits into
adoptium:masterfrom
MattyWeee123:issue4858
Closed

Trial the latest Dacapo v23.11-chopin#6341
MattyWeee123 wants to merge 32 commits into
adoptium:masterfrom
MattyWeee123:issue4858

Conversation

@MattyWeee123

Copy link
Copy Markdown
Contributor

Fixes: #4858

Replacing the original sourceforge download with a zip cannot
be directly passed as decapo.jar. Its contents should be extracted and
the correct jar file inside should be decapo.jar.

Fixes: adoptium#6306

Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
Observed that only one main jar file is in the upper
most directory and the remaining jar files are probably
dependecies. Changed build.xml to fit logic.

Fixes: adoptium#6306

Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
Observed directory structure after downloading the
decapo zip locally, and stoopped trying to pattern
match. Hard coded movement of the main decapo jar
file.

Fixes: adoptium#6306

Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
ran out of space during extraction.

Extract only the relevant decapo.jar file from the
zip and removed redundant temporary directory.

Fixes: adoptium#6306

Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
ran out of space during extraction.

Extract only the relevant decapo.jar file from the
zip and removed redundant temporary directory.

Fixes: adoptium#6306

Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
Encountering issue where grinder can't find any
tests, wondering if this is because of other
dependencies in the zip.

Fixes: adoptium#6306

Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
Unzips file directly to source and renames to
decapo.jar and dacapo. File structure is as
expected.

Fixes: adoptium#6306

Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
Swapped to dacapo-minimal that has size more
suitable for functional testing. Rearranged file
name variables for easy changes.

Fixes: adoptium#6306

Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
Parametrized decapo version in download link since
its already in DACAPO_DIR_NAME.

Fixes: adoptium#6306

Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
Want to double check behavior of ${TEST_ROOT} in
dacapo/build.xml.

Fixes: adoptium#6326

Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
Checking if zip is being properly retrived via the
LIB declaration, file import, and the targets
compile and get_zip.

Fixes: adoptium#6326

Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
Seeing if code moves maven tar file into src as expected,
since production TKG does not have updated dacapo dependency.

Fixes: adoptium#6326

Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
Maven works as expected, should be simple transition to dacapo once TKG
PR is merged. Fixed race condition with debug echo not being in an
ordered target.

Fixes: adoptium#6326

Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
Parametrized the dependency filename, swapped LIB value from
maven to dacapo.

Fixes: adoptium#6326

Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
Currently downloading empty file probably due to
the link being needing a redirect to sourceforge.
Sanity check in aqa-test first, then maybe make a
PR to change getDependentLibs in getDependencies.xml.

Fixes: adoptium#6326

Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
The dacaopo depency in getDependencies.pl currently
uses an indirect link, so I executed the shell command
directly with curl option -L instead of using the one
imported from getDependencies.xml.

Fixes: adoptium#6326

Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
@MattyWeee123 MattyWeee123 marked this pull request as ready for review June 15, 2025 19:16
@karianna karianna requested review from llxia and smlambert June 15, 2025 22:20
Comment thread perf/dacapo/build.xml

<target name="getDependentLibs">
<exec executable="perl" failonerror="true">
<arg line="${TEST_ROOT}/TKG/scripts/getDependencies.pl -path ${LIB_DIR} -task default -dependencyList ${LIB} -curlOpts -L"/>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not use getDependencies.pl. Please just update the original code <var name="curl_options" value="-Lks -C - https://sourceforge.net/projects/dacapobench/files/latest/download -o dacapo.jar"/> to download the dacapo-23.11-MR2-chopin-minimal jar.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please see #6338 (comment)

@MattyWeee123 MattyWeee123 deleted the issue4858 branch June 17, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trial the latest Dacapo v23.11-chopin

3 participants