Skip to content

semantic-release fix - part 2#25

Merged
alexkli merged 2 commits intomasterfrom
semantic-release2
Jul 22, 2020
Merged

semantic-release fix - part 2#25
alexkli merged 2 commits intomasterfrom
semantic-release2

Conversation

@alexkli
Copy link
Copy Markdown
Contributor

@alexkli alexkli commented Jul 22, 2020

Follow up from #23 trying to get it to work.

  • order linux first in OS list
  • try after_script for coverage report, so it doesn't run (and fail) as part of releases

@alexkli alexkli requested review from jdelbick and tmathern July 22, 2020 00:08
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 22, 2020

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           61        61           
=========================================
  Hits            61        61           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a8cd52...0fae93c. Read the comment docs.

@alexkli
Copy link
Copy Markdown
Contributor Author

alexkli commented Jul 22, 2020

after_script worked so far, it ran in the normal jobs: https://travis-ci.com/github/adobe/node-cgroup-metrics/jobs/363551478

Merging with admin privileges to test if the release works now.

@alexkli alexkli merged commit 32b675a into master Jul 22, 2020
@alexkli alexkli deleted the semantic-release2 branch July 22, 2020 00:53
@alexkli
Copy link
Copy Markdown
Contributor Author

alexkli commented Jul 22, 2020

Mostly worked, and semantic-release was triggered, but now it failed with This operation requires a one-time password from your authenticator. because likely the NPM token set in travis is old and needs a new one. Will try to update it.

@adobe-bot
Copy link
Copy Markdown

🎉 This PR is included in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants