Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #23   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           70        61    -9     
  Branches        12         0   -12     
=========================================
- Hits            70        61    -9     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c6bb5e...2ce76f2. Read the comment docs.

Let's see if it works :)

Unfortunately, semantic release did not work: https://travis-ci.com/github/adobe/node-cgroup-metrics/jobs/363544630

Not quite sure what the issue is, but I see these discrepancies:

1. it ran the release stage on Windows (why?), but we say condition: $TRAVIS_OS_NAME == linux so it skipped it, doing no release
2. it run npm run report-coverage which failed as it did not run npm test before (we don't need to report coverage here)

Ok, possible answers:

1. the .travis.yml here listed windows before linux, maybe that tells Travis what OS to use for the release/deploy stage

2. this seems to happen everywhere, but get ignored. see here, expand the npm run report-coverage part in the logs and see it fails too: https://travis-ci.com/github/adobe/aio-cli-plugin-asset-compute/jobs/363148121

   • maybe we should switch to after_script so it doesn't run after deploy (which is where we run the release): https://docs.travis-ci.com/user/job-lifecycle/

Drop the other OS from travis.yml: https://github.com/adobe/node-cgroup-metrics/blob/master/.travis.yml#L12
This will be a start. Also drop https://github.com/adobe/node-cgroup-metrics/blob/master/.travis.yml#L17, we already test 10.15 and 10.19 (should reduce wait times too).

And there seems to be a syntax issue: https://github.com/adobe/node-cgroup-metrics/blob/master/.travis.yml#L39, there should only be one = for the test, according to documentation (https://docs.travis-ci.com/user/deployment-v2/conditional)

#24

See #25.

#25 mostly worked, and semantic-release was triggered, but now it failed with This operation requires a one-time password from your authenticator. because likely the NPM token set in travis is old and needs a new one. Will try to update it.

Latest try in #27.

🎉 This PR is included in version 3.0.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

Worked!

Regarding 2. from above: after_script did not help, it also runs on the release stage, see https://travis-ci.com/github/adobe/node-cgroup-metrics/jobs/363568375

But it doesn't fail it either, so we can just keep ignoring it. Suggest we stick to after_success.