Target SDK should attach response tokens in the retrieveLocationContent data callback#155
Conversation
sbenedicadb
left a comment
There was a problem hiding this comment.
looks good - couple questions we can chat about on the side.
probably a good idea to run the UpdateVersions GH action to ensure we didn't miss anything
| import Foundation | ||
|
|
||
| extension NamedCollectionDataStore { | ||
| static func clear(appGroup: String? = nil) { |
There was a problem hiding this comment.
this is useful across all our extensions - have you talked with @timkimadobe about getting it added to our test-utils framework?
| if let appGroup = appGroup, | ||
| !appGroup.isEmpty, | ||
| let userDefaults = UserDefaults(suiteName: appGroup) { | ||
| for _ in 0 ... 5 { |
There was a problem hiding this comment.
do we have a better way to iterate through defaults to clear them? curious as to why we are using a for loop here.
There was a problem hiding this comment.
This code has been around for a bit to ensure the defaults get cleared. You can find it elsewhere too, see https://github.com/adobe/aepsdk-core-ios/blob/main/AEPCore/Mocks/UserDefaults%2BClear.swift.
…nt data callback (#155) (#156) * Target SDK should attach response tokens in the retrieveLocationContent data callback * Minor fixes * • reverted dependency updates • updated test constants * revert podfile.lock * Fixed tests after migration from UserDefaults to file system. * minor cleanup * Additional test + doc update Co-authored-by: Steve Benedick <sbenedic@adobe.com>
…nt data callback (#155) (#156) (#157) * Target SDK should attach response tokens in the retrieveLocationContent data callback * Minor fixes * • reverted dependency updates • updated test constants * revert podfile.lock * Fixed tests after migration from UserDefaults to file system. * minor cleanup * Additional test + doc update Co-authored-by: Steve Benedick <sbenedic@adobe.com>
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: