Skip to content

Update Target SDK for min iOS11/ Xcode14.1#138

Merged
swarna04 merged 18 commits intoadobe:dev-v4.0.0from
swarna04:MOB-18851
Jun 6, 2023
Merged

Update Target SDK for min iOS11/ Xcode14.1#138
swarna04 merged 18 commits intoadobe:dev-v4.0.0from
swarna04:MOB-18851

Conversation

@swarna04
Copy link
Copy Markdown
Contributor

@swarna04 swarna04 commented May 31, 2023

Description

Ref: [MOB-18851]

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@swarna04 swarna04 changed the base branch from main to dev-v4.0.0 May 31, 2023 20:50
macos:
xcode: 13.0.0 # Specify the Xcode version to use
- validate-code
- test-ios
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be a colon here

test-ios:

@swarna04 swarna04 changed the title [MOB-18851] Update Target SDK for min iOS11/ Xcode14 [MOB-18851] Update Target SDK for min iOS11/ Xcode14.1 Jun 1, 2023
@swarna04 swarna04 changed the title [MOB-18851] Update Target SDK for min iOS11/ Xcode14.1 Update Target SDK for min iOS11/ Xcode14.1 Jun 1, 2023
Copy link
Copy Markdown
Contributor

@rymorale rymorale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@swarna04 swarna04 merged commit fa3d730 into adobe:dev-v4.0.0 Jun 6, 2023
swarna04 added a commit that referenced this pull request Jun 7, 2023
* Updated docs for Target Raw APIs

* Feedback updates + cleanup

* Fixed SPM PIF generation issue

* Prepare Target SDK for min iOS 11/ Xcode 14 support

* Fixed .xcresult path required for CodeCov

* minor fixes

* config yml fix

* Fixed minor issue in release yml

* Updated pod dependencies

* Adding new SystemInfoService method for locale to mock service.

* Updated SwiftLint dependency to use v0.52.0. Fixed lint issues.

* makefile minor fix

* Updated pod dependencies

* Minor project + lint related fixes

* Updated pod dependencies
swarna04 added a commit that referenced this pull request Jun 7, 2023
* Updated docs for Target Raw APIs

* Feedback updates + cleanup

* Fixed SPM PIF generation issue

* Prepare Target SDK for min iOS 11/ Xcode 14 support

* Fixed .xcresult path required for CodeCov

* minor fixes

* config yml fix

* Fixed minor issue in release yml

* Updated pod dependencies

* Adding new SystemInfoService method for locale to mock service.

* Updated SwiftLint dependency to use v0.52.0. Fixed lint issues.

* makefile minor fix

* Updated pod dependencies

* Minor project + lint related fixes

* Updated pod dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants