Skip to content

Enable Target preview by default if not enabled via configuration#128

Merged
swarna04 merged 2 commits intoadobe:dev-v3.3.1from
swarna04:MOB-18241
Mar 1, 2023
Merged

Enable Target preview by default if not enabled via configuration#128
swarna04 merged 2 commits intoadobe:dev-v3.3.1from
swarna04:MOB-18241

Conversation

@swarna04
Copy link
Copy Markdown
Contributor

@swarna04 swarna04 commented Mar 1, 2023

Description

Ref: [MOB-18241]

If not specified programmatically, assume target.previewEnabled to be true (by default).

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@swarna04 swarna04 requested a review from sbenedicadb March 1, 2023 03:01
@swarna04 swarna04 changed the base branch from main to dev-v3.3.1 March 1, 2023 20:18
@swarna04 swarna04 merged commit c29e881 into adobe:dev-v3.3.1 Mar 1, 2023
swarna04 added a commit that referenced this pull request Mar 2, 2023
…) (#129)

* Enable preview by default if not enabled via configuration

* Updated the Target SDK version
swarna04 added a commit that referenced this pull request Mar 2, 2023
* Enable Target preview by default if not enabled via configuration (#128)

* Enable preview by default if not enabled via configuration

* Updated the Target SDK version

* Fixed build script (#130)
swarna04 added a commit that referenced this pull request Mar 2, 2023
* Fixed build script

* re: dev -> main (v3.3.1) (#131)

* Enable Target preview by default if not enabled via configuration (#128)

* Enable preview by default if not enabled via configuration

* Updated the Target SDK version

* Fixed build script (#130)

* Reverted script updates
swarna04 added a commit that referenced this pull request Mar 2, 2023
* Fixed build script

* re: dev -> main (v3.3.1) (#131)

* Enable Target preview by default if not enabled via configuration (#128)

* Enable preview by default if not enabled via configuration

* Updated the Target SDK version

* Fixed build script (#130)

* Reverted script updates

* Reverted SPM integration script updates
swarna04 added a commit that referenced this pull request Mar 2, 2023
* Enable Target preview by default if not enabled via configuration (#128)

* Enable preview by default if not enabled via configuration

* Updated the Target SDK version

* Fixed build script (#130)

* Reverted SPM integration script updates (#132)

* Fixed build script

* re: dev -> main (v3.3.1) (#131)

* Enable Target preview by default if not enabled via configuration (#128)

* Enable preview by default if not enabled via configuration

* Updated the Target SDK version

* Fixed build script (#130)

* Reverted script updates

* More SPM script updates (#133)

* Fixed build script

* re: dev -> main (v3.3.1) (#131)

* Enable Target preview by default if not enabled via configuration (#128)

* Enable preview by default if not enabled via configuration

* Updated the Target SDK version

* Fixed build script (#130)

* Reverted script updates

* Reverted SPM integration script updates

* Merge main to dev-v3.3.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants