Skip to content

Merge to Staging for v4.2.0 release#385

Merged
kevinlind merged 13 commits intostagingfrom
dev
Aug 24, 2023
Merged

Merge to Staging for v4.2.0 release#385
kevinlind merged 13 commits intostagingfrom
dev

Conversation

@timkimadobe
Copy link
Copy Markdown
Contributor

Description

Merge to staging for v4.2.0 release:

  1. Added support for completion events

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

kevinlind and others added 11 commits July 21, 2023 14:31
Merge to Main for 4.1.0 release
Downmerge Main to Dev after v4.1.0 release
Update the validation expected results for recordSeparator.
In iOS 17 and later, result displays " " (empty string).
In iOS 16 and before, result displays "\u{0000}".
Add tvOS versions check
Update the recordSeparator check with a variable.
Update the validation expected results for recordSeparator in functional tests
* Add new process on complete to NetworkResponseHandler

* Refactor existing test based on changed return type

* Add functional test for new complete event

* Add network response handler functional tests

* Update constant names to CONTENT_COMPLETE

Add more functional test cases for onComplete behavior

* Add new request send completion flag section

Correct the documentation for response content as a fallback to error response content
Alphabetize items

* Add test button for sending event with complete flag

Reorganize view to move scrollable data view to the top and not truncate text
Add visual indicators to scrollable data view

* Add explicit types

* Apply swift lint

* Fix line length violation

* Update method docs to reflect new return type

* Refactor test case to use assertion helper

* Align event reference doc with android version
* Updating version to 4.2.0.

* Update the Podfile.lock with version updates

---------

Co-authored-by: timkimadobe <timkimadobe@users.noreply.github.com>
Co-authored-by: timkimadobe <95260439+timkimadobe@users.noreply.github.com>
@timkimadobe timkimadobe requested review from addb and kevinlind August 24, 2023 21:47
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 24, 2023

Codecov Report

Merging #385 (3963826) into staging (a006885) will increase coverage by 0.04%.
Report is 2 commits behind head on staging.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           staging     #385      +/-   ##
===========================================
+ Coverage    96.73%   96.77%   +0.04%     
===========================================
  Files           27       27              
  Lines         1653     1671      +18     
===========================================
+ Hits          1599     1617      +18     
  Misses          54       54              

@kevinlind kevinlind merged commit 0db9697 into staging Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants