Update the validation expected results for recordSeparator in functional tests#382
Merged
Update the validation expected results for recordSeparator in functional tests#382
Conversation
Update the validation expected results for recordSeparator.
In iOS 17 and later, result displays " " (empty string).
In iOS 16 and before, result displays "\u{0000}".
Add tvOS versions check
Codecov Report
@@ Coverage Diff @@
## dev #382 +/- ##
=======================================
Coverage 96.73% 96.73%
=======================================
Files 27 27
Lines 1653 1653
=======================================
Hits 1599 1599
Misses 54 54 |
kevinlind
approved these changes
Aug 18, 2023
Contributor
kevinlind
left a comment
There was a problem hiding this comment.
Looks good.
What you have is fine but another option would be to create a variable for the expected string then use the string in each test.
if #available(iOS 17, tvOS 17, *) {
let expectedRecordSeparatorString = ""
} else {
let expectedRecordSeparatorString = "\u{0000}"
}
Update the recordSeparator check with a variable.
Contributor
Author
Thanks Kevin, I Iike the way you suggest. Updated with that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MOB-19331
Update the validation expected results for recordSeparator.
In iOS 17 and later, result displays " " (empty string).
In iOS 16 and before, result displays "\u{0000}".
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: