[MOB-16628] Full tvOS support#255
Merged
emdobrin merged 15 commits intoadobe:feature/tvosfrom Jul 22, 2022
Merged
Conversation
Downmerge main -> dev after v1.4.1 release
emdobrin
reviewed
Jul 19, 2022
Contributor
emdobrin
left a comment
There was a problem hiding this comment.
There is also a test failure, seems related to the scheme names conflict. We resolved a similar issue in adobe/aepsdk-edgeidentity-ios#71
emdobrin
reviewed
Jul 19, 2022
emdobrin
reviewed
Jul 21, 2022
Contributor
emdobrin
left a comment
There was a problem hiding this comment.
looks good with the new changes, some minor comments
Codecov Report
@@ Coverage Diff @@
## feature/tvos #255 +/- ##
================================================
- Coverage 94.59% 91.94% -2.65%
================================================
Files 27 27
Lines 998 992 -6
================================================
- Hits 944 912 -32
- Misses 54 80 +26 |
emdobrin
approved these changes
Jul 21, 2022
addb
added a commit
that referenced
this pull request
Feb 22, 2023
* [MOB-16628] Full tvOS support (#255) * [MOB-16628] Add targets and schemes to AEPEdge xcode project for tvOS support. * [MOB-16628] Added and updated scripts for tvOS support * [MOB-16628] Added tvOS testApp target and refactored the app. * [MOB-16628] Update to Xcode 13 * Fix makefile * [MOB-16628] Refactor testApp and script fixes * Rearrange TestApp UI elements * [MOB-16628] Update implementationDetails for tvOS * Fix tests * [MOB-16628] Update Package.swift * Test cleanup * Revert the min version for ios pods in test-podspec script * Add min pod version for tvOS test project in test-podspec script * Update test-podspec script Co-authored-by: Emilia Dobrin <33132425+emdobrin@users.noreply.github.com> * App fixes to support tvOS * Get latest changes, import tvOS branch code for edgeConsent and edgeIdentity to test. Improved app code. --------- Co-authored-by: Emilia Dobrin <33132425+emdobrin@users.noreply.github.com> Co-authored-by: Kevin Lind <40409666+kevinlind@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: