Conversation
Merge to Main for v1.2.0 release
Downmerge Main to Dev after v1.2.0 release
* Allow custom domain in Edge endpoint URL. Read Configuration shared state for 'edge.domain' key. Change EdgeEndpoint from enum to struct to hold endpoint URL as String. Build URL based on type (prod, pre-prod, int) and custom domain. * Adding unit tests for EdgeEndpoint * Set pre-commit githook access to executable * Add unit tests to EdgeHitProcessor to validate using custom Edge endpoint domains * Update method comments in EdgeEndpoint * Rename EdgeEndpointType to EdgeEnvironmentType * Set domain lowercased in cleanDomain instead of deletePrefix. * Sort UnitTests folder in Xcode * Move lowercased call to EdgeEnvironmentType * Update EdgeEnvironmentType comment
* Bump version to 1.3.0 * Update Pods for AEPCommerceDemoApp, uses new AEPEdge version
Codecov Report
@@ Coverage Diff @@
## staging #229 +/- ##
===========================================
+ Coverage 94.45% 94.51% +0.06%
===========================================
Files 27 27
Lines 973 983 +10
===========================================
+ Hits 919 929 +10
Misses 54 54 |
emdobrin
approved these changes
Jan 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Merge to Staging for version 1.3.0 release.
Includes:
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: