Use custom domain for Edge endpoint when configured#227
Merged
Use custom domain for Edge endpoint when configured#227
Conversation
Read Configuration shared state for 'edge.domain' key. Change EdgeEndpoint from enum to struct to hold endpoint URL as String. Build URL based on type (prod, pre-prod, int) and custom domain.
Codecov Report
@@ Coverage Diff @@
## dev #227 +/- ##
==========================================
+ Coverage 94.45% 94.51% +0.06%
==========================================
Files 27 27
Lines 973 983 +10
==========================================
+ Hits 919 929 +10
Misses 54 54 |
emdobrin
reviewed
Jan 8, 2022
Contributor
emdobrin
left a comment
There was a problem hiding this comment.
Looks good overall 👍 , left few comments below
emdobrin
approved these changes
Jan 11, 2022
| @@ -13,7 +13,7 @@ | |||
| import Foundation | |||
|
|
|||
| /// Represents all the known endpoints for the Edge Network | |||
Contributor
There was a problem hiding this comment.
Let's update the comments on this enum since is not directly related to the endpoints. E.g. Represents all the known Edge Network environment types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Read Configuration shared state for 'edge.domain' key. Change EdgeEndpoint from enum to struct to hold endpoint URL as String. Build URL based on type (prod, pre-prod, int) and custom domain.
Internal ticket: MOB-14959
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: