Replace hardcoded event source with EventSource.CONTENT_COMPLETE#89
Merged
emdobrin merged 3 commits intoadobe:dev-v2.3.0from Aug 31, 2023
Merged
Replace hardcoded event source with EventSource.CONTENT_COMPLETE#89emdobrin merged 3 commits intoadobe:dev-v2.3.0from
emdobrin merged 3 commits intoadobe:dev-v2.3.0from
Conversation
Codecov Report
@@ Coverage Diff @@
## dev-v2.3.0 #89 +/- ##
================================================
- Coverage 83.84% 83.59% -0.25%
Complexity 385 385
================================================
Files 29 29
Lines 1578 1578
Branches 223 223
================================================
- Hits 1323 1319 -4
- Misses 161 165 +4
Partials 94 94
Flags with carried forward coverage won't be shown. Click here to find out more.
|
timkimadobe
approved these changes
Aug 30, 2023
emdobrin
approved these changes
Aug 31, 2023
timkimadobe
added a commit
that referenced
this pull request
Sep 18, 2023
* Fix warnings in Gradle files (#80) * Fix deprecated use of * Fix Groovy warnings in build files * Dispatch 'complete' event when streaming connection closed (#83) * Send 'complete' event after all response handles are recieved when requested * Update event source variable names to match source name 'CONTENT_COMPLETE' * Reword method description for sendCompletionRequested * Add more tests to bump coverage numbers * Add Content Complete event to event-reference documentation * Update event-reference with sendCompletion property and response content definition. * Capitalize 'Defined' in table for completion event description * Bump version to 2.3.0 * Add content complete event to toc, update response content description * Revert 'asNode(null)' to 'asNode()'. Using 'asNode()' gives warning about implicit null value, however passing 'asNode(null)' fails to build publish step. * Replace hardcoded event source with EventSource.CONTENT_COMPLETE (#89) * Set Core dependency to 2.4.0 * Replace hardcoded event source with EventSource.CONTENT_COMPLETE * Fix failing deep copy test after Core changes to ignore invalid objects. * Initial setup of integration test class and dependencies * Enable passing test suite preset values via command line and IDE Update integration test setup steps * Add convenience method setExpectationForNetworkRequest that accepts a testable network request First integration test case * Add new test constants for edge integration testing, alphabetized * Add integration test cases and helpers * Update integration test core dependency version to 2.4.0 * Add more test cases * Apply lint formatting * Create helper resetTestExpectations() and update TestHelper.resetTestExpectations call * Remove unused methods * Refactor networkResponses to store list of all responses for given request Refactor usages Update documentation * Revert makefile changes for followup PR * Add back junit Assert import lost after merge resolution * Fix other merge issues * Rename setResponseConnectionFor to setResponseFor to match iOS naming --------- Co-authored-by: Kevin Lind <40409666+kevinlind@users.noreply.github.com> Co-authored-by: Kevin Lind <lind@adobe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: