Skip to content

Merge to Staging for 2.3.0 Gradle fix for publish#88

Merged
kevinlind merged 2 commits intostagingfrom
dev-v2.3.0
Aug 25, 2023
Merged

Merge to Staging for 2.3.0 Gradle fix for publish#88
kevinlind merged 2 commits intostagingfrom
dev-v2.3.0

Conversation

@kevinlind
Copy link
Copy Markdown
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

kevinlind and others added 2 commits August 25, 2023 11:21
Using 'asNode()' gives warning about implicit null value, however passing 'asNode(null)' fails to build publish step.
Revert 'asNode(null)' to 'asNode()'.
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 25, 2023

Codecov Report

Merging #88 (2773a7d) into staging (5d322f8) will not change coverage.
Report is 1 commits behind head on staging.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             staging      #88   +/-   ##
==========================================
  Coverage      83.84%   83.84%           
  Complexity       385      385           
==========================================
  Files             29       29           
  Lines           1578     1578           
  Branches         223      223           
==========================================
  Hits            1323     1323           
  Misses           161      161           
  Partials          94       94           
Flag Coverage Δ
functional-tests 66.48% <ø> (ø)
unit-tests 79.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@kevinlind kevinlind merged commit cd5d61f into staging Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant