Revert 'asNode(null)' to 'asNode()'.#87
Merged
kevinlind merged 1 commit intoadobe:dev-v2.3.0from Aug 25, 2023
Merged
Conversation
Using 'asNode()' gives warning about implicit null value, however passing 'asNode(null)' fails to build publish step.
timkimadobe
approved these changes
Aug 25, 2023
Codecov Report
@@ Coverage Diff @@
## dev-v2.3.0 #87 +/- ##
=============================================
Coverage 83.84% 83.84%
Complexity 385 385
=============================================
Files 29 29
Lines 1578 1578
Branches 223 223
=============================================
Hits 1323 1323
Misses 161 161
Partials 94 94
Flags with carried forward coverage won't be shown. Click here to find out more. |
addb
approved these changes
Aug 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using 'asNode()' gives warning about implicit null value, however passing 'asNode(null)' fails to build publish step.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: