Conversation
Staging -> Main [v2.1.0 release]
* Set Core dependency to 2.2.0 which adds support for chaining events * Add functional test to assert getLocationHint response event chained to request event * Set parentId for events dispatched from NetworkResponseHandler * Add functional tests for parentId set in response events * Update test case with real-world use case * Add log message when dispatching response Event without parent id * Make format to fix indentations
Set parent ID to Edge response events (#69)
…d warnings (#72) * In network response, look for eventIndex under report object for errors and warnings * Do not encode eventIndex in errors or warnings response. * Get 'report' directly from error/warning response instead of using DataReader
addb
reviewed
Jul 14, 2023
Codecov Report
@@ Coverage Diff @@
## staging #74 +/- ##
=============================================
+ Coverage 83.28% 83.63% +0.35%
- Complexity 367 380 +13
=============================================
Files 29 29
Lines 1555 1582 +27
Branches 219 225 +6
=============================================
+ Hits 1295 1323 +28
- Misses 161 162 +1
+ Partials 99 97 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
emdobrin
approved these changes
Jul 14, 2023
addb
approved these changes
Jul 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Merge to Staging for v2.2.0 release:
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: