Set parent ID to Edge response events (#69)#71
Merged
kevinlind merged 1 commit intodev-v2.2.0from Jul 10, 2023
Merged
Conversation
* Set Core dependency to 2.2.0 which adds support for chaining events * Add functional test to assert getLocationHint response event chained to request event * Set parentId for events dispatched from NetworkResponseHandler * Add functional tests for parentId set in response events * Update test case with real-world use case * Add log message when dispatching response Event without parent id * Make format to fix indentations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set Core dependency to 2.2.0 which adds support for chaining events
Add functional test to assert getLocationHint response event chained to request event
Set parentId for events dispatched from NetworkResponseHandler
Add functional tests for parentId set in response events
Update test case with real-world use case
Add log message when dispatching response Event without parent id
Make format to fix indentations
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: