Skip to content

Set parent ID to Edge response events (#69)#71

Merged
kevinlind merged 1 commit intodev-v2.2.0from
dev-v2.1.0
Jul 10, 2023
Merged

Set parent ID to Edge response events (#69)#71
kevinlind merged 1 commit intodev-v2.2.0from
dev-v2.1.0

Conversation

@kevinlind
Copy link
Copy Markdown
Contributor

  • Set Core dependency to 2.2.0 which adds support for chaining events

  • Add functional test to assert getLocationHint response event chained to request event

  • Set parentId for events dispatched from NetworkResponseHandler

  • Add functional tests for parentId set in response events

  • Update test case with real-world use case

  • Add log message when dispatching response Event without parent id

  • Make format to fix indentations

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

* Set Core dependency to 2.2.0 which adds support for chaining events

* Add functional test to assert getLocationHint response event chained to request event

* Set parentId for events dispatched from NetworkResponseHandler

* Add functional tests for parentId set in response events

* Update test case with real-world use case

* Add log message when dispatching response Event without parent id

* Make format to fix indentations
@kevinlind kevinlind merged commit c425bd0 into dev-v2.2.0 Jul 10, 2023
@kevinlind kevinlind deleted the dev-v2.1.0 branch July 21, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant