Skip to content

Update dependencies to remove Edge from chain#46

Merged
timkimadobe merged 2 commits intoadobe:dev-v2.0.1from
timkimadobe:update-dependencies
Feb 9, 2023
Merged

Update dependencies to remove Edge from chain#46
timkimadobe merged 2 commits intoadobe:dev-v2.0.1from
timkimadobe:update-dependencies

Conversation

@timkimadobe
Copy link
Copy Markdown
Contributor

@timkimadobe timkimadobe commented Feb 9, 2023

Description

This PR adds an exclusion to EdgeConsent dependency to prevent it from bringing in Edge as a dependency (since in the Edge repo case, Edge classes are brought in from the project itself) using:
exclude group: 'com.adobe.marketing.mobile', module: 'edge'

exclude was used instead of transitive = false since it is the double inclusion of Edge as a dependency (from project and from EdgeConsent dependency) that is causing the issue.

This should fix the duplicate class error where gradle task task ':app:mergeDexDebug' was failing because Type com.adobe.marketing.mobile.CompletionCallbacksManager$1 is defined multiple times:

* What went wrong:
Execution failed for task ':app:mergeDexDebug'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.DexMergingTaskDelegate
   > There was a failure while executing work items
      > A failure occurred while executing com.android.build.gradle.internal.tasks.DexMergingWorkAction
         > com.android.builder.dexing.DexArchiveMergerException: Error while merging dex archives: 
           Type com.adobe.marketing.mobile.CompletionCallbacksManager$1 is defined multiple times: /Users/timothyk/git/timkimadobe/aepsdk-edge-android/code/edge/build/.transforms/c293c6fbd5ddd91d7e9359fb7ba6e4ea/transformed/classes/classes.dex, /Users/timothyk/git/timkimadobe/aepsdk-edge-android/code/app/build/intermediates/external_libs_dex/debug/mergeExtDexDebug/classes.dex
           Learn how to resolve the issue at https://developer.android.com/studio/build/dependencies#duplicate_classes.

From: https://app.circleci.com/pipelines/github/adobe/aepsdk-edge-android/134/workflows/12ed3b41-f5a8-46c0-9bc5-983d1ce0b15b

Triggered by PR: #45

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 9, 2023

Codecov Report

Merging #46 (60f4d70) into dev-v2.0.1 (4501cc8) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             dev-v2.0.1      #46   +/-   ##
=============================================
  Coverage         83.28%   83.28%           
- Complexity          367      368    +1     
=============================================
  Files                29       29           
  Lines              1555     1555           
  Branches            219      219           
=============================================
  Hits               1295     1295           
  Misses              161      161           
  Partials             99       99           
Flag Coverage Δ
functional-tests 65.85% <ø> (ø)
unit-tests 79.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@timkimadobe timkimadobe merged commit 7d74455 into adobe:dev-v2.0.1 Feb 9, 2023
@timkimadobe timkimadobe deleted the update-dependencies branch February 9, 2023 22:52
@emdobrin emdobrin added this to the v2.0.1 milestone Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants