Update dependencies to remove Edge from chain#46
Merged
timkimadobe merged 2 commits intoadobe:dev-v2.0.1from Feb 9, 2023
Merged
Update dependencies to remove Edge from chain#46timkimadobe merged 2 commits intoadobe:dev-v2.0.1from
timkimadobe merged 2 commits intoadobe:dev-v2.0.1from
Conversation
10 tasks
emdobrin
approved these changes
Feb 9, 2023
Codecov Report
@@ Coverage Diff @@
## dev-v2.0.1 #46 +/- ##
=============================================
Coverage 83.28% 83.28%
- Complexity 367 368 +1
=============================================
Files 29 29
Lines 1555 1555
Branches 219 219
=============================================
Hits 1295 1295
Misses 161 161
Partials 99 99
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an exclusion to EdgeConsent dependency to prevent it from bringing in Edge as a dependency (since in the Edge repo case, Edge classes are brought in from the project itself) using:
exclude group: 'com.adobe.marketing.mobile', module: 'edge'excludewas used instead oftransitive = falsesince it is the double inclusion of Edge as a dependency (from project and from EdgeConsent dependency) that is causing the issue.This should fix the duplicate class error where gradle task
task ':app:mergeDexDebug'was failing becauseType com.adobe.marketing.mobile.CompletionCallbacksManager$1 is defined multiple times:From: https://app.circleci.com/pipelines/github/adobe/aepsdk-edge-android/134/workflows/12ed3b41-f5a8-46c0-9bc5-983d1ce0b15b
Triggered by PR: #45
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: