Skip to content

Remove kotlin syntax from api docs#45

Merged
timkimadobe merged 3 commits intoadobe:dev-v2.0.1from
timkimadobe:api-reference-remove-kotlin-syntax
Feb 9, 2023
Merged

Remove kotlin syntax from api docs#45
timkimadobe merged 3 commits intoadobe:dev-v2.0.1from
timkimadobe:api-reference-remove-kotlin-syntax

Conversation

@timkimadobe
Copy link
Copy Markdown
Contributor

@timkimadobe timkimadobe commented Feb 8, 2023 •
edited
Loading

Description

This PR removes Kotlin syntax from API docs, since the actual Kotlin API signatures (when implemented) may be different than a direct conversion from existing Java syntax.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@timkimadobe timkimadobe changed the base branch from main to dev-v2.0.1 February 8, 2023 23:51
@cacheung cacheung self-requested a review February 9, 2023 00:40
@emdobrin
Copy link
Copy Markdown
Contributor

emdobrin commented Feb 9, 2023

@timkimadobe can you verify the app build failure on this PR?

@timkimadobe
Copy link
Copy Markdown
Contributor Author

timkimadobe commented Feb 9, 2023

Yes, @emdobrin please see the proposed fix for the build issue here: #46

@timkimadobe timkimadobe mentioned this pull request Feb 9, 2023
Merged
10 tasks
@timkimadobe timkimadobe changed the base branch from dev-v2.0.1 to main February 9, 2023 22:55
@timkimadobe timkimadobe changed the base branch from main to dev-v2.0.1 February 9, 2023 22:55
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 9, 2023

Codecov Report

Merging #45 (b06788d) into dev-v2.0.1 (7d74455) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             dev-v2.0.1      #45   +/-   ##
=============================================
  Coverage         79.16%   79.16%           
  Complexity          359      359           
=============================================
  Files                29       29           
  Lines              1555     1555           
  Branches            219      219           
=============================================
  Hits               1231     1231           
  Misses              223      223           
  Partials            101      101
Flag Coverage Δ
unit-tests 79.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@timkimadobe timkimadobe merged commit 66eac87 into adobe:dev-v2.0.1 Feb 9, 2023
@timkimadobe timkimadobe deleted the api-reference-remove-kotlin-syntax branch February 9, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addb addb addb approved these changes

@cacheung cacheung cacheung approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@timkimadobe @emdobrin @addb @cacheung