Filter out AnalyticsBase and AnalyticsAppExtension classes from initialize API#1125
Merged
kevinlind merged 1 commit intoadobe:dev-v5.4.1from Apr 18, 2025
Merged
Conversation
… of extensions filtered out when using initialize API. The Analytics extension defines a base class AnalyticsBase which adopts Extension plus two subclasses of AnalyticsBase, Analytics and AnalyticsAppExtension. The initialize API would find and register all three of these classes to the SDK tripling the count of each tracking event. The fix is to filter out these extensions so only the Analytics class is registered. The initialize API is not supported in app extensions, so customers building app extensions with Analytics would need to use the registerExtensions API anyway.
cdhoffmann
approved these changes
Apr 18, 2025
kevinlind
added a commit
that referenced
this pull request
May 9, 2025
Filter out AnalyticsBase and AnalyticsAppExtension classes from initialize API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include 'AnalyticsBase.Type' and 'AnalyticsAppExtension.Type' to list of extensions filtered out when using initialize API.
The Analytics extension defines a base class AnalyticsBase which adopts Extension plus two subclasses of AnalyticsBase, Analytics and AnalyticsAppExtension. The initialize API would find and register all three of these classes to the SDK tripling the count of each tracking event. The fix is to filter out these extensions so only the Analytics class is registered. The initialize API is not supported in app extensions, so customers building app extensions with Analytics would need to use the registerExtensions API anyway.
See: Jira MOB-23276
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: