Implement event history insert and insertIfNotExists consequence support by timkimadobe · Pull Request #1121 · adobe/aepsdk-core-ios

timkimadobe · 2025-03-11T01:37:53Z

Description

This PR implements support for the new insert and insertIfNotExists consequence support in the Core RulesEngine, leveraging the existing rules condition evaluation logic to trigger these consequences.

The consequence handling has been updated to handle the new schema consequence type, and https://ns.adobe.com/personalization/eventHistoryOperation schema value.

At a high level, the consequence object has three high level properties:

Name	Key	Type	Description
Operation type	operation	string	Required Determines the type of database operation to be performed on Event History by the SDK. - Insert: Inserts a record in the Event History Database. - Insert if not exists: Inserts a record in the Event History Database only if there is not already a matching record with a matching hash value.
Key-value pairs	content	object	Optional Provided key-value pairs will be added to the string used to generate the event history hash. If the value represents a token that the SDK knows how to resolve, the resolved value will be used (such as shared state values, ~timestampu, etc.).
Event Data Mask	keys	array	Optional An array of strings that designate which keys in the event will be used for generating the event history hash.

The primary logic for this new support is handled in the new LaunchRulesEngine processEventHistoryOperation method:

Checks that the required property of operation exists (which could be either insert or insertIfNotExists, but does not strictly require these two values for future expansion)
The consequence's keys are separated into two groups - event data keys and token keys: -
- Token keys: keys that are prefixed with ~ (ex: ~sdkver)
- Event data keys: All other keys
Token keys are reformatted and resolved
1. Each token key is placed into a new dictionary where the key is the token and the value is the token wrapped in the LaunchRulesEngine token delimiters
  - ["~sdkver": "{%~sdkver%}"]
    2 This dictionary is resolved using the TokenFinder used to resolve the original rules condition
The historical event to be recorded's event data is set up with the original triggering event's data payload
The token key dictionary is merged into the data dictionary
The consequence's custom content key value pairs are merged in (the content key value pairs' tokens were already replaced by the overall consequence resolution)
The event mask is set up with all of the keys from keys (that is, event data keys and token keys) and content
Create the historical event to be recorded with the merged event data and final mask
If insertIfNotExists, first check that the hash for the event does not already exist
- NOTE: A new API, eventExists has been created in in EventHistory to support easily checking for the hash value instead of having to extract all the key value pairs from the flattened map as is required by the existing getEvents API's EventHistoryRequest input format requirement
Insert the historical event into the record
On successful insert, also dispatch the event recorded as a rules consequence event so extensions dependent on event history inserts can respond

Questions for reviewers

processEventHistoryOperation uses direct string keys - how do we feel about this? Should we use constants here instead? If so where should they live?:

if let keys = schemaData["keys"] as? [String] {

The dispatch consequence event for insert and insertIfNotExists happens inside the processing method itself, not inside the evaluateRules loop, because the EventHistory methods it depends on are async methods. Is the approach taken acceptable? Should we also be keeping track of dispatchChainCount here?

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

spoorthipujariadobe · 2025-03-27T20:44:06Z

AEPCore/Sources/rules/LaunchRulesEngine.swift

+    ///   - data: a `Traversable` object used for token resolution
+    private func processSchemaConsequence(consequence: RuleConsequence, processedEvent: Event, data: Traversable) {
+        guard let schema = consequence.schema else {
+            Log.error(label: LOG_TAG, "(\(self.name)) : Unable to process a Schema Consequence, 'schema' is missing from 'details'")


nit: As per the definition of schema consequence type, the id and data are also mandatory fields. Wondering if we should have that check here and fast fail

Thank you! That's a great point - I believe Messaging does this as well (through the decoding mechanism, and having those properties as non-optional). I've updated the check for all three properties to be here

…levels

sbenedicadb

looking good so far, a few things to address

sbenedicadb · 2025-03-27T22:16:56Z

AEPCore/Mocks/PublicTestUtils/TestableExtensionRuntime.swift

+    public func recordHistoricalEvent(_ event: AEPCore.Event, handler: ((Bool) -> Void)?) {
+        // no-op
+    }
+
+    public func historicalEventExists(_ event: AEPCore.Event, handler: @escaping (Bool) -> Void) {
+        // no-op
+    }
+


i'd recommend adding two things to the new methods in this mock:

call the handler with a value that can be provided by the caller.

keep a boolean value that keeps track of when the method has been called

Thank you! Added support for both points

sbenedicadb · 2025-03-27T22:50:14Z

AEPCore/Sources/eventhub/EventHub.swift

+    ///   - event: the `Event` to be recorded in the Event History database
+    ///   - handler: called with a `Bool` indicating a successful database insert
+    func recordHistoricalEvent(_ event: Event, handler: ((Bool) -> Void)? = nil) {
+        eventHistory?.recordEvent(event, handler: handler)


should handler be called with false here if eventHistory is nil?

Thank you that's a great point, I think it should. I noticed that getHistoricalEvents also has potential for a nil eventHistory instance, but doesn't have a fallback completion handler call so I added ?? handler([]). What do you think?

yup, seems good

sbenedicadb · 2025-03-27T22:57:58Z

AEPCore/Sources/eventhub/ExtensionContainer.swift

    }

+    func recordHistoricalEvent(_ event: Event, handler: ((Bool) -> Void)?) {
+        guard let eventHub = eventHub else { return }


same question here, should we call the handler?

Yes, updated!

sbenedicadb · 2025-03-27T22:58:43Z

AEPCore/Sources/eventhub/history/EventHistory.swift

    ///   - handler: called with a `Bool` indicating a successful database insert.
    func recordEvent(_ event: Event, handler: ((Bool) -> Void)? = nil) {
        guard event.eventHash != 0 else {
+            Log.debug(label: LOG_TAG, "Failed to record event in history - event hash is 0")


sbenedicadb · 2025-03-27T23:04:22Z

AEPCore/Sources/eventhub/history/EventHistory.swift

+    /// - Parameters:
+    ///   - event: the `Event` to check for existence in the Event History database
+    ///   - handler: called with a `Bool` indicating if an event with the same hash exists
+    func eventExists(_ event: Event, handler: @escaping (Bool) -> Void) {


do we need this function? don't we achieve the same thing by calling getEvents?

That's a great point - I had created this because it was quite difficult to convert an Event into the EventHistoryRequest format getEvents required in the context of the processEventHistoryOperation method. My first thought was since Event itself easily converts into a hash, but none of the EventHistory APIs accept a hash directly, to add support by providing a new API in the form of this eventExists

But on second thought, given your feedback, if the issue was the difficulty of converting Event into the EventHistoryRequest format, then simply adding support for that conversion (in the new Event+EventHistoryRequest.swift) and then leveraging the existing getEvents:

Avoids creating a narrow and brittle use case API in EventHistory

Adds support for other use cases that would need the Event -> EventHistoryRequest in the future

What do you think of this updated approach?

perfect - i think that's a great plan 👍

sbenedicadb · 2025-03-27T23:10:41Z

AEPCore/Sources/eventhub/history/EventHistoryDatabase.swift

@@ -61,6 +61,7 @@ class EventHistoryDatabase {
        dispatchQueue.async {


not your code, but can we add a capture of [weak self] for any of these async blocks where we are using self so we can prevent potential leaking?

Yes! I added the [weak self] guarded usage, added log messages for that case, and updated the log prefix to be static

sbenedicadb · 2025-03-27T23:26:40Z

AEPCore/Sources/rules/LaunchRulesEngine.swift

+    ///   - data: a `Traversable` object used for token resolution
+    private func processSchemaConsequence(consequence: RuleConsequence, processedEvent: Event, data: Traversable) {
+        guard let schema = consequence.schema, let _ = consequence.data, let _ = consequence.detailID else {
+            Log.error(label: LOG_TAG, "(\(self.name)) : Unable to process Schema Consequence with ID: \(consequence.id). A Schema Consequence requires 'schema', 'data', and 'id' properties.")


let's change this to a warn please

sbenedicadb · 2025-03-27T23:32:13Z

AEPCore/Sources/rules/LaunchRulesEngine.swift

+    ///   - consequence: the RuleConsequence which contains the event history operation details
+    ///   - processedEvent: the event that triggered the rule
+    ///   - data: a `Traversable` object used for token resolution
+    private func processEventHistoryOperation(consequence: RuleConsequence, processedEvent: Event, data: Traversable) {


let's get the magic strings out of this method:

operation

keys

~

content

Thank you! Extracted them to the top of the file, unless there's a better place to put them you had in mind?

sbenedicadb · 2025-03-27T23:33:08Z

AEPCore/Sources/rules/LaunchRulesEngine.swift

+    ///   - data: a `Traversable` object used for token resolution
+    private func processEventHistoryOperation(consequence: RuleConsequence, processedEvent: Event, data: Traversable) {
+        guard let schemaData = consequence.data, let operation = schemaData["operation"] as? String else {
+            Log.error(label: LOG_TAG, "(\(self.name)) : Unable to process an EventHistoryOperation Consequence with ID: \(consequence.id). Required 'operation' field missing from 'detail.data'.")


please change to warn

sbenedicadb · 2025-03-27T23:45:27Z

AEPCore/Sources/rules/LaunchRulesEngine.swift

+                if success {
+                    self.extensionRuntime.dispatch(event: eventToRecord)
+                } else {
+                    Log.error(label: self.LOG_TAG, "(\(self.name)) : Failed to record event in history with operation '\(operation)'")


…xists API and update usages

…lEvents

…Event method in TestableExtensionRuntime

timkimadobe

Thanks so much for the review @sbenedicadb! Updated based on feedback

timkimadobe · 2025-03-28T00:56:24Z

AEPCore/Sources/eventhub/history/EventHistory.swift

+    /// - Parameters:
+    ///   - event: the `Event` to check for existence in the Event History database
+    ///   - handler: called with a `Bool` indicating if an event with the same hash exists
+    func eventExists(_ event: Event, handler: @escaping (Bool) -> Void) {


That's a great point - I had created this because it was quite difficult to convert an Event into the EventHistoryRequest format getEvents required in the context of the processEventHistoryOperation method. My first thought was since Event itself easily converts into a hash, but none of the EventHistory APIs accept a hash directly, to add support by providing a new API in the form of this eventExists

But on second thought, given your feedback, if the issue was the difficulty of converting Event into the EventHistoryRequest format, then simply adding support for that conversion (in the new Event+EventHistoryRequest.swift) and then leveraging the existing getEvents:

Avoids creating a narrow and brittle use case API in EventHistory

Adds support for other use cases that would need the Event -> EventHistoryRequest in the future

What do you think of this updated approach?

timkimadobe · 2025-03-28T01:01:29Z

AEPCore/Sources/eventhub/EventHub.swift

+    ///   - event: the `Event` to be recorded in the Event History database
+    ///   - handler: called with a `Bool` indicating a successful database insert
+    func recordHistoricalEvent(_ event: Event, handler: ((Bool) -> Void)? = nil) {
+        eventHistory?.recordEvent(event, handler: handler)


Thank you that's a great point, I think it should. I noticed that getHistoricalEvents also has potential for a nil eventHistory instance, but doesn't have a fallback completion handler call so I added ?? handler([]). What do you think?

timkimadobe · 2025-03-28T01:02:47Z

AEPCore/Sources/eventhub/ExtensionContainer.swift

    }

+    func recordHistoricalEvent(_ event: Event, handler: ((Bool) -> Void)?) {
+        guard let eventHub = eventHub else { return }


Yes, updated!

timkimadobe · 2025-03-28T01:17:29Z

AEPCore/Sources/eventhub/history/EventHistoryDatabase.swift

@@ -61,6 +61,7 @@ class EventHistoryDatabase {
        dispatchQueue.async {


Yes! I added the [weak self] guarded usage, added log messages for that case, and updated the log prefix to be static

timkimadobe · 2025-03-28T01:21:21Z

AEPCore/Sources/rules/LaunchRulesEngine.swift

+    ///   - data: a `Traversable` object used for token resolution
+    private func processSchemaConsequence(consequence: RuleConsequence, processedEvent: Event, data: Traversable) {
+        guard let schema = consequence.schema, let _ = consequence.data, let _ = consequence.detailID else {
+            Log.error(label: LOG_TAG, "(\(self.name)) : Unable to process Schema Consequence with ID: \(consequence.id). A Schema Consequence requires 'schema', 'data', and 'id' properties.")


timkimadobe · 2025-03-28T01:21:34Z

AEPCore/Sources/rules/LaunchRulesEngine.swift

+    ///   - data: a `Traversable` object used for token resolution
+    private func processEventHistoryOperation(consequence: RuleConsequence, processedEvent: Event, data: Traversable) {
+        guard let schemaData = consequence.data, let operation = schemaData["operation"] as? String else {
+            Log.error(label: LOG_TAG, "(\(self.name)) : Unable to process an EventHistoryOperation Consequence with ID: \(consequence.id). Required 'operation' field missing from 'detail.data'.")


timkimadobe · 2025-03-28T01:22:01Z

AEPCore/Sources/rules/LaunchRulesEngine.swift

+                if success {
+                    self.extensionRuntime.dispatch(event: eventToRecord)
+                } else {
+                    Log.error(label: self.LOG_TAG, "(\(self.name)) : Failed to record event in history with operation '\(operation)'")


timkimadobe · 2025-03-28T01:26:49Z

AEPCore/Sources/rules/LaunchRulesEngine.swift

+    ///   - consequence: the RuleConsequence which contains the event history operation details
+    ///   - processedEvent: the event that triggered the rule
+    ///   - data: a `Traversable` object used for token resolution
+    private func processEventHistoryOperation(consequence: RuleConsequence, processedEvent: Event, data: Traversable) {


Thank you! Extracted them to the top of the file, unless there's a better place to put them you had in mind?

timkimadobe · 2025-03-28T01:42:47Z

AEPCore/Mocks/PublicTestUtils/TestableExtensionRuntime.swift

+    public func recordHistoricalEvent(_ event: AEPCore.Event, handler: ((Bool) -> Void)?) {
+        // no-op
+    }
+
+    public func historicalEventExists(_ event: AEPCore.Event, handler: @escaping (Bool) -> Void) {
+        // no-op
+    }
+


Thank you! Added support for both points

spoorthipujariadobe · 2025-03-28T15:02:52Z

AEPCore/Sources/rules/LaunchRulesEngine.swift

+        var tokenDictionary: [String: Any?] = [:]
+        if !tokenKeys.isEmpty {
+            for key in tokenKeys {
+                tokenDictionary[key] = "\(LaunchRulesEngine.LAUNCH_RULE_TOKEN_LEFT_DELIMITER)\(key)\(LaunchRulesEngine.LAUNCH_RULE_TOKEN_RIGHT_DELIMITER)"


On L173, we're traversing through the entire rule consequence and already parsing all tokens inside {%...%} and replacing them with values from event data.
Wondering if we should have the place where the rule is authored add in whatever is inside the keys part with those delimiters so we don't do this manual addition here and this looks consistent with the other attach and modify consequence . The rule we receive from the server would look like this

{ "id": "123", "type": "schema", "detail": { "id": "abc", "schema": "https://ns.adobe.com/personalization/eventHistoryOperation", "data": { "operation": "insert", "keys": [ "keyToWriteToEventHistory: {%keyInEventData%}" ], "content": { "key": "value" } } } }

Thoughts?

I think you're right - in the proposal I had seen an example keys with token values not already wrapped in the token delimiters, so I implemented based on that. However, given how attach and modify consequences work today and expect the values to be replaced as tokens to already be wrapped in the delimiters, I agree that we should require the rule author to do the wrapping

But with the current logic and given that in the proposal, keys is an array of Strings and can have a mix of event keys and token keys, if the replacement happens on L173, how do we know which are event keys and which are token keys with their values resolved?

Ex:
["event.key", "{%~type%}"] --(resolved on L173)--> ["event.key", "com.adobe.eventType.analytics"]

Then in the logic of the schema consequence to pull from the event data using the keys array, how do we:

Know which were originally event keys and which were tokens and

Know what the original token name was, since tokens need to be set in the hash with the token name as key and resolved value as value?

I believe the LaunchTokenFinder already has the logic for this today. If the value starts with ~ followed by a known type, like type, source, state, the appropriate value is read. If ~ is followed by an unknown string, we attempt to read from the event data.

I might have misunderstood your question. I get your point now. We need to pass the event data keys in the mask array to write to event history. That's what you were getting at right? We might need move token keys to content part and keep event keys in the keys :

{ "id": "123", "type": "schema", "detail": { "id": "abc", "schema": "https://ns.adobe.com/personalization/eventHistoryOperation", "data": { "operation": "insert", "keys": ["keyInEventData"], "content": { "key": "value", "eventType": "{%~type%}", "keyToWriteToEventHistory": "{%~tokenToBeReplacedFromEventData%} } } } }

Adding the tokens to content would also avoid us calling EventDataMerger.merge twice

Yes, I think moving the token keys to content would solve this. @sbenedicadb what do you think?

After discussion with Steve, I think we landed on removing support for the keys property in the consequence for now, at least until a clear use case for the property comes up - I've updated the implementation to reflect this, please let me know what you think!

AEPCore/Sources/eventhub/history/Event+EventHistoryRequest.swift

spoorthipujariadobe

LGTM! Lets add tests to cover the new rule consequences

* Implement event history insert and insertIfNotExists consequence support (#1121) * Implement event history insert and insertIfNotExists consequence support * Add method stubs * Update API dump * Clean up TestableExtensionRuntime * Add early exit check for schema consequence, update log messages and levels * Dispatch consequence event for insert and insertIfNotExists success * Add Event to EventHistoryRequest conversion support and remove eventExists API and update usages * Add nil case handler calls for recordHistoricalEvent and getHistoricalEvents * Add weak self to closures and update LOG_PREFIX to static instance * Update log levels from error to warning * Extract strings from dictionary access logic into constants * Add method call and result configuration support for recordHistoricalEvent method in TestableExtensionRuntime * Fix early exit case for no keys specified to record in consequence * Remove support for the `keys` property * Add back content empty check early exit, improve logging detail * Extract repeated log info into variable * Update eventHistoryOperation logic to align with Android, clean up unused constants (#1133) * Create protocols for EventHistory and EventHistoryDatabase and update EventHub to use dependency injection for EventHistory Update MockEventHistoryDatabase to use new EventHistoryDatabaseService protocol Update EventHistory and EventHistoryDatabase to conform to their respective protocols Update MockEventHistory to conform to EventHistoryService protocol and fix implementation Fix EventHubEventHistoryTests to use the instantiated eventhub instance not the shared one # Conflicts: # AEPCore.xcodeproj/project.pbxproj # AEPCore/Mocks/PublicTestUtils/MockEventHistoryDatabase.swift # AEPCore/Tests/EventHubTests/EventHubEventHistoryTests.swift # AEPCore/Tests/TestHelpers/MockEventHistory.swift * Fix merge * Fix event history operation `insertIfNotExists` logical error and race with insert operation (#1134) * Fix insertIfNotExists escaping closure operation race with insert operation * Remove max time deadline for getHistoricalEvents in historical event consequence processing Add check for database error value in CONSEQUENCE_EVENT_HISTORY_OPERATION_INSERT_IF_NOT_EXISTS logic and improve logging around this value * Remove unused constant * Split log lines * Update EventHub's eventHistory reference from var to let * Update protocol names and add storage property to EventHistoryProvider Update EventHistory init to accommodate this read only access to the backing storage * Delete incorrectly renamed file * Pod update * Add test coverage and support implementation for EventHub EventHistory related method tests * Add test coverage for new Event toEventHistoryRequest * Add documentation notes to keep initializers consistent * Create protocols for EventHistory and EventHistoryDatabase and update EventHub to use dependency injection for EventHistory Update MockEventHistoryDatabase to use new EventHistoryDatabaseService protocol Update EventHistory and EventHistoryDatabase to conform to their respective protocols Update MockEventHistory to conform to EventHistoryService protocol and fix implementation Fix EventHubEventHistoryTests to use the instantiated eventhub instance not the shared one * Fix merge * Fix merge * Fix merge - remove old EventHistoryDatabaseService.swift and EventHistoryService.swift * Update MockEventHistory to conform to EventHistoryProvider * Fix rebase errors * Update Event_EventHistoryRequestTests to better test nested structures * Update EventHubEventHistoryTests to clean up event names and descriptions * Run pod update * Create rules engine test base class and implement test cases for historical event operation # Conflicts: # AEPCore.xcodeproj/project.pbxproj * Clean up code * Add event record, dispatch, and payload validation * Clean up comments * Update insertIfNotExists test to check the database error case Remove unneeded getHistoricalEvents delay helper in mock * Fix project file inclusion post rebase * Run pod update * Implement the mostRecent search type handler * Fix logical error in description * Create tests for most recent condition cases * Add functional tests for mostRecent condition working in rules engine * Add test cases to EventHistoryTests to improve coverage for the "more than one" event case Update MockEventHistoryDatabase to enable this testing * Update test case to differentiate return values * Update search type logic to handle setting value more elegantly and remove default value logging Replace search type operand handling with switch Refactor getHistoricalEventCount with switch instead of nested if else and add early exit guard for unsupported type Fix doc error * Create unit tests for JSONCondition's getHistoricalEventCount method * Add back added test file * Fix missing dispatch schema consequence event for non-historical event operation * Fix project structure * Add support for array flattening and add and update tests * Add ability for all_url to not use the new array flattening logic for backwards compatibility * Update examples for clarity * Apply swift formatting * Add dictionary shape test and update test case comment * Add test cases for flattenArrays false, tighten test case expectations for some cases * Fix NSNull values filtering in the FNV1A32 hash generation and test parity with Android * Update historical condition consequence to use the generateConsequenceEvent method to dispatch consequence Update test cases * Update test cases to validate new recorded and dispatched events * Update event history getEvents logs to trace * Add resource class to install_dependencies * Update to Xcode 15.3 * Update iOS/tvOS devices to 17.4 * Fix missing Xcode version upgrade * Fix files lost in merge --------- Co-authored-by: Steve Benedick <sbenedic@adobe.com>

Implement event history insert and insertIfNotExists consequence support

c0f8029

timkimadobe requested review from sbenedicadb and spoorthipujariadobe March 11, 2025 01:38

timkimadobe added 3 commits March 19, 2025 14:33

Add method stubs

013f4ca

Update API dump

734e858

Clean up TestableExtensionRuntime

166478d

spoorthipujariadobe reviewed Mar 27, 2025

View reviewed changes

Add early exit check for schema consequence, update log messages and …

f0d428b

…levels

timkimadobe requested a review from spoorthipujariadobe March 27, 2025 22:52

Dispatch consequence event for insert and insertIfNotExists success

c3e9e70

sbenedicadb reviewed Mar 27, 2025

View reviewed changes

timkimadobe added 6 commits March 27, 2025 17:50

Add Event to EventHistoryRequest conversion support and remove eventE…

54402c8

…xists API and update usages

Add nil case handler calls for recordHistoricalEvent and getHistorica…

4ef32f5

…lEvents

Add weak self to closures and update LOG_PREFIX to static instance

3efd0fa

Update log levels from error to warning

6fad9c7

Extract strings from dictionary access logic into constants

0dd3ed3

Add method call and result configuration support for recordHistorical…

84229ee

…Event method in TestableExtensionRuntime

timkimadobe commented Mar 28, 2025

View reviewed changes

timkimadobe requested a review from sbenedicadb March 28, 2025 01:45

spoorthipujariadobe reviewed Mar 28, 2025

View reviewed changes

spoorthipujariadobe reviewed Apr 1, 2025

View reviewed changes

AEPCore/Sources/eventhub/history/Event+EventHistoryRequest.swift Show resolved Hide resolved

timkimadobe added 4 commits April 2, 2025 14:59

Fix early exit case for no keys specified to record in consequence

d5a55ea

Remove support for the keys property

0cfbee8

Add back content empty check early exit, improve logging detail

6c20689

Extract repeated log info into variable

24a9e5d

timkimadobe requested a review from spoorthipujariadobe April 3, 2025 01:31

spoorthipujariadobe approved these changes Apr 11, 2025

View reviewed changes

timkimadobe merged commit 27eb383 into adobe:dev-v5.4.0 Apr 15, 2025
17 checks passed

timkimadobe deleted the feature-event-history-insert branch April 15, 2025 21:30

timkimadobe mentioned this pull request Apr 18, 2025

Add tests for new insert rules consequence (part 1) #1126

Closed

10 tasks

This was referenced Apr 21, 2025

Add tests for new insert rules consequence (part 1) #1132

Closed

Add tests for new insert rules consequence (part 1) v2 #1137

Merged

timkimadobe mentioned this pull request Jul 25, 2025

Support new historical rules condition and consequences #1162

Merged

10 tasks

		@@ -61,6 +61,7 @@ class EventHistoryDatabase {
		dispatchQueue.async {

Conversation

timkimadobe commented Mar 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Questions for reviewers

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

spoorthipujariadobe Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sbenedicadb left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

timkimadobe left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

timkimadobe commented Mar 11, 2025 •

edited

Loading

spoorthipujariadobe Mar 27, 2025 •

edited

Loading

spoorthipujariadobe Mar 28, 2025 •

edited

Loading

timkimadobe Mar 28, 2025 •

edited

Loading

spoorthipujariadobe Mar 31, 2025 •

edited

Loading